LGTM3 /Daniel
On 2024-08-21 17:53, Alex Russell wrote:
LGTM2 On Monday, August 19, 2024 at 5:58:15 PM UTC-7 Domenic Denicola wrote: Thanks! LGTM1. On Tue, Aug 20, 2024 at 4:25 AM Frank Liberato <liber...@google.com> wrote: > It'd be ideal to land this before we approve the intent. Merged, including your suggested change to make the description paragraph normative. thanks -fl On Wednesday, August 7, 2024 at 10:40:49 PM UTC-7 dom...@chromium.org wrote: On Thu, Aug 8, 2024 at 4:55 AM Chromestatus <ad...@cr-status.appspotmail.com> wrote: Contact emails libe...@chromium.org, ste...@chromium.org Explainer None Specification https://github.com/WICG/document-picture-in-picture/pull/119 <https://github.com/WICG/document-picture-in-picture/pull/119> It'd be ideal to land this before we approve the intent. Summary This adds a new parameter ("preferInitialWindowPlacement") to the document picture-in-picture API that, when set to true, hints to the user agent that it should not try to reuse the position or size of the previous document picture-in-picture from this site when opening this one. Often, a document picture-in-picture window will close and re-open multiple times for the same site, such as moving a video conference to and from PiP. The user agent is free to re-open the PiP window at its most recent size / location, so that it stays where the user last moved it and provides continuity between the PiP windows. However, if the new window is semantically unrelated to the previous window, such as if it is a new VC, then the developer can use this parameter provide a hint to the user agent that this window might be better opened in its default position / size instead. Blink component Blink>Media>PictureInPicture <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EMedia%3EPictureInPicture> TAG review None TAG review status Pending Note that Document PiP already got a review <https://github.com/w3ctag/design-reviews/issues/798> ("unsatisfied") from the TAG. So although per the process <https://www.chromium.org/blink/guidelines/api-owners/process-exceptions/>, I think this change would require a TAG review, I am comfortable granting an exception for this kind of small extension to an already-reviewed feature, which is probably not a good use of the TAG's time. If other API owners disagree, please speak up! Risks Interoperability and Compatibility None /Gecko/: No signal (https://github.com/mozilla/standards-positions/issues/670#issuecomment-2072932641 <https://github.com/mozilla/standards-positions/issues/670#issuecomment-2072932641>) /WebKit/: No signal (https://github.com/WebKit/standards-positions/issues/41#issuecomment-2072931535 <https://github.com/WebKit/standards-positions/issues/41#issuecomment-2072931535>) /Web developers/: Positive (https://github.com/WICG/document-picture-in-picture/issues/120 <https://github.com/WICG/document-picture-in-picture/issues/120>) /Other signals/: WebView application risks Does this intent deprecate or change behavior of existing APIs, such that it has potentially high risk for Android WebView-based applications? None Debuggability None Will this feature be supported on all six Blink platforms (Windows, Mac, Linux, ChromeOS, Android, and Android WebView)? No Is this feature fully tested by web-platform-tests <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md>? No Flag name on chrome://flags None Finch feature name None Non-finch justification not required due to "Simple parameter changes (adding params, changing the type etc.)" -- this feature simply adds one boolean to an existing param structure. Requires code in //chrome? False Adoption expectation Feature is used by specific partners within 12 months of launch in chrome. Estimated milestones Shipping on desktop 129 Anticipated spec changes Open questions about a feature may be a source of future web compat or interop issues. Please list open issues (e.g. links to known github issues in the project for the feature specification) whose resolution may introduce web compat/interop risk (e.g., changing to naming or structure of the API in a non-backward-compatible way). N/A Link to entry on the Chrome Platform Status https://chromestatus.com/feature/5183881532932096?gate=5113170869092352 <https://chromestatus.com/feature/5183881532932096?gate=5113170869092352> Links to previous Intent discussions Intent to Prototype: https://groups.google.com/a/chromium.org/d/msgid/blink-dev/30002034-794f-4c61-a6f1-186ba7ff004dn%40chromium <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/30002034-794f-4c61-a6f1-186ba7ff004dn%40chromium> This intent message was generated by Chrome Platform Status <https://chromestatus.com>.-- You received this message because you are subscribedto the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/000000000000b9d50c061f1d4ad6%40google.com <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/000000000000b9d50c061f1d4ad6%40google.com?utm_medium=email&utm_source=footer>. --You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/c1c62c82-7e26-41bf-859e-b107e6fcb5e4n%40chromium.org <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/c1c62c82-7e26-41bf-859e-b107e6fcb5e4n%40chromium.org?utm_medium=email&utm_source=footer>.
-- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/937c6a43-786e-4ae2-bdd2-a70df3148ec2%40gmail.com.
