LGTM3 On Tue, Aug 13, 2024 at 11:56 AM Daniel Bratell <bratel...@gmail.com> wrote:
> LGTM2 > > /Daniel > On 2024-08-13 08:51, Domenic Denicola wrote: > > It looks like you have requested all the reviews and closed all the issues > I pointed out. LGTM1! > > On Wednesday, August 7, 2024 at 9:20:26 AM UTC+9 Domenic Denicola wrote: > >> Can you request the Privacy, Security, Enterprise, Debuggability, and >> Testing gates in Chrome Status, filling out the required questions there? >> >> On Wed, Aug 7, 2024 at 7:53 AM Chromestatus < >> ad...@cr-status.appspotmail.com> wrote: >> >>> Contact emails ft...@google.com >>> >>> Explainer https://github.com/tc39/proposal-intl-duration-format >>> >>> Specification https://tc39.es/proposal-intl-duration-format >>> >>> Design docs >>> >>> https://docs.google.com/document/d/1UMwkeeiqVyVNhNW8CS1vwN9g2cIH0AryaU16DT-vGg0/edit >>> >>> Summary >>> >>> Intl.DurationFormat API is a TC39 ECMA402 proposal See >>> https://github.com/tc39/proposal-intl-duration-format for the proposal >>> The proposal advanced to Stage 3 on 2021-10 Spec: >>> https://tc39.es/proposal-intl-duration-format/ >>> >>> >>> Blink component Blink>JavaScript>Internationalization >>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EJavaScript%3EInternationalization> >>> >>> TAG review None >>> >>> TAG review status Not applicable >>> >>> Risks >>> >>> >>> Interoperability and Compatibility >>> >>> The spec is sync with Temporal . If Temporal dramatically change the >>> definition of Temporal Duration, we may need to adjust the implemetation >>> >>> >>> *Gecko*: Positive (https://bugzilla.mozilla.org/show_bug.cgi?id=1648139) >>> >>> >>> *WebKit*: Shipped/Shipping ( >>> https://bugs.webkit.org/show_bug.cgi?id=214794) >>> https://developer.apple.com/documentation/safari-release-notes/safari-16_4-release-notes >>> >>> *Web developers*: Positive ( >>> https://github.com/tc39/ecma402-mdn/issues/22) >>> https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/DurationFormat >>> >>> *Other signals*: >>> >>> Ergonomics >>> >>> Temporal.Duration as defined in >>> https://tc39.es/proposal-temporal/#sec-temporal-maximumtemporaldurationroundingincrement >>> >>> >>> WebView application risks >>> >>> Does this intent deprecate or change behavior of existing APIs, such >>> that it has potentially high risk for Android WebView-based applications? >>> >>> low >>> >>> >>> Debuggability >>> >>> Will this feature be supported on all six Blink platforms (Windows, Mac, >>> Linux, ChromeOS, Android, and Android WebView)? Yes >>> >>> Is this feature fully tested by web-platform-tests >>> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >>> ? Yes >>> >>> https://github.com/tc39/test262/issues/3305 >>> >>> >>> Flag name on chrome://flags harmony_intl_duration_format >>> >>> Finch feature name None >>> >>> Non-finch justification >>> >>> v8 >>> >>> >>> Requires code in //chrome? False >>> >>> Tracking bug https://bugs.chromium.org/p/v8/issues/detail?id=11660 >>> >>> Measurement Use Count CL is under review in >>> https://chromium-review.googlesource.com/c/chromium/src/+/5646725 >>> >>> Availability expectation Feature is available on Web Platform mainline >>> within 6 months of launch in Chrome. >>> >>> Adoption expectation Feature is considered a best practice for some use >>> case within 6 months of reaching Web Platform baseline. >>> >>> Adoption plan intl dev team inside google will rewrite closure duration >>> format to use this feature with a thinner wrapper >>> >>> Non-OSS dependencies >>> >>> Does the feature depend on any code or APIs outside the Chromium open >>> source repository and its open-source dependencies to function? >>> The feature depend on ICU and therefore also CLDR project >>> >>> Sample links >>> >>> https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/DurationFormat >>> >>> Estimated milestones >>> Shipping on desktop 129 >>> DevTrial on desktop 128 >>> Shipping on Android 129 >>> DevTrial on Android 128 >>> >>> Anticipated spec changes >>> >>> Open questions about a feature may be a source of future web compat or >>> interop issues. Please list open issues (e.g. links to known github issues >>> in the project for the feature specification) whose resolution may >>> introduce web compat/interop risk (e.g., changing to naming or structure of >>> the API in a non-backward-compatible way). >>> https://github.com/tc39/proposal-intl-duration-format/issues >> >> >> Looking through these, the following look like they might cause compat >> issues as part of resolving them: >> >> - https://github.com/tc39/proposal-intl-duration-format/issues/115 >> - https://github.com/tc39/proposal-intl-duration-format/issues/64 >> - https://github.com/tc39/proposal-intl-duration-format/issues/192 >> - https://github.com/tc39/proposal-intl-duration-format/issues/204 >> >> I'm guessing these are not a big deal, because the spec has already >> reached stage 3 and shipped in Safari. But, can you confirm that you do not >> anticipate any changes from resolving these issues? (Maybe you can work on >> closing the issues?) >> >> >>> >>> >>> Link to entry on the Chrome Platform Status >>> https://chromestatus.com/feature/5193021205774336?gate=4584540429877248 >>> >>> Links to previous Intent discussions Intent to Prototype: >>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOcELL-vykLL8UDTG1QcKptGfyRPw8T6StP2%2BqMPFv09aUHPbg%40mail.gmail.com >>> Ready for Trial: >>> https://groups.google.com/a/chromium.org/g/blink-dev/c/TTdMixrlxfk/m/pqSxKmsnAQAJ >>> Intent to Ship: >>> https://groups.google.com/a/chromium.org/g/blink-dev/c/Ft8-RWx0e2Q/m/sjx53DocAQAJ >>> >>> >>> This intent message was generated by Chrome Platform Status >>> <https://chromestatus.com>. >>> >> -- >>> You received this message because you are subscribed to the Google >>> Groups "blink-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to blink-dev+unsubscr...@chromium.org. >>> To view this discussion on the web visit >>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/0000000000001c3c21061f0ba971%40google.com >>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/0000000000001c3c21061f0ba971%40google.com?utm_medium=email&utm_source=footer> >>> . >>> >> -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/07fc7633-6372-4006-83d4-3c128708b55cn%40chromium.org > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/07fc7633-6372-4006-83d4-3c128708b55cn%40chromium.org?utm_medium=email&utm_source=footer> > . > > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/5e5262ab-70ff-4af5-9717-7b2bcc781fdd%40gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/5e5262ab-70ff-4af5-9717-7b2bcc781fdd%40gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CADsXd2M1bj-LgNSSg2nLDQr3SuZ_a4%2BLO5CqV4BJCC5Ry0k5OQ%40mail.gmail.com.
