LGTM to experiment M129-M134 inclusive.
On Tue, Jul 30, 2024 at 9:39 PM Daseul Lee <ds...@chromium.org> wrote: > Contact emails > > asu...@chromium.org, a...@chromium.org, christin...@chromium.org, > ds...@chromium.org, memm...@chromium.org > > Explainer > > https://github.com/whatwg/fs/blob/main/proposals/FileSystemObserver.md > > Specification > > https://github.com/whatwg/fs/pull/165 > > Design docs > > > https://docs.google.com/document/d/1d6YoPvk0rdNBQaZcoFP-V5u4CBjgahvmnVsZpbn0Gmo/edit?usp=sharing > Thanks for the public design doc! It's a shame that the security review is hidden behind a Google-internal doc <https://docs.google.com/document/d/1Nqi9p2QWmjvW9blua21VFyVz9-ivBGHKLCZ_DF16GNM/edit?tab=t.0> and the Launch process. While I understand how some security related discussions can't be made public, it would have been good for me as a reviewer to get a better understanding of e.g. the UI patterns that users will go through in order to approve a site to watch their files/directories. At the same time, I trust the Chrome security folks on this. > Summary > > The FileSystemObserver interface notifies websites of changes to the file > system. Sites observe changes to files and directories in the user's local > device (as specified in WICG/file-system-access) or in the Bucket File > System (as specified in whatwg/fs), and are notified of basic change info, > such as the change type. > > Blink component > > Blink>Storage>FileSystem > <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EStorage%3EFileSystem> > > TAG review > > Exempt per early TAG design review: > https://github.com/w3ctag/design-reviews/issues/868 > > > RisksInteroperability and Compatibility > > Gecko: Positive (https://github.com/mozilla/standards-positions/issues/942) > Positive on use-case > > WebKit: No signal ( > https://github.com/WebKit/standards-positions/issues/291) > > Web developers: Strongly positive ( > https://github.com/WICG/file-system-access/issues/72) > > Other signals: > > WebView application risks > > Does this intent deprecate or change behavior of existing APIs, such that > it has potentially high risk for Android WebView-based applications? > > Not enabled in WebView > > > Goals for experimentation > > - Obtain more web developer feedback to validate the API shape > > - Identify any major performance issues against real world use cases, that > could help determining future improvements and optimizations > > Ongoing technical constraints > > None > > Debuggability > > N/A > > Will this feature be supported on all six Blink platforms (Windows, Mac, > Linux, ChromeOS, Android, and Android WebView)? > > No. Available on desktop only. > > Is this feature fully tested by web-platform-tests > <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> > ? > > Yes > > > https://wpt.fyi/results/fs/FileSystemObserver.https.tentative.window.html?label=experimental&label=master&aligned > > Flag name on chrome://flags > > file-system-observer > > Finch feature name > > FileSystemObserver > > Requires code in //chrome? > > False > > Tracking bug > > https://issues.chromium.org/40105284 > > Launch bug > > https://launch.corp.google.com/launch/4261040 > > Estimated milestones > > Origin trial desktop first > > 129 > > Origin trial desktop last > > 134 > > Link to entry on the Chrome Platform Status > > https://chromestatus.com/feature/4622243656630272?gate=5110010073317376 > > Links to previous Intent discussions > > Intent to prototype: > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGnvaEXNQ0OUo61DXeuhzARPyOu_E6vA6VsD6%2BBwVDGW_0BQJw%40mail.gmail.com > > This intent message was generated by Chrome Platform Status > <https://chromestatus.com/>. > > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAPhTbOjWuKV_MpRhG3bZ3Oj%3Dy5eQCvdR6iGBDrM%2BqTGpwgiWGQ%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAPhTbOjWuKV_MpRhG3bZ3Oj%3Dy5eQCvdR6iGBDrM%2BqTGpwgiWGQ%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOmohSLWO3ZsMZ6VzwytSrGZ5eYAp_PVKx3kOek1kSkp_A3pEw%40mail.gmail.com.
