LGTM1 /Daniel
On 2024-07-25 00:22, Mason Freed wrote:
On Wed, Jul 17, 2024 at 11:51 PM Yoav Weiss (@Shopify) <[email protected]> wrote:Have you had a chance to investigate what a breakage looks like by checking the sites using the feature? More specifically, as discussed previously, this usage is coming from a 3P app that merchant sites install and that Shopify has no direct control over. Have you reached out to the app's authors? Have you tried to see if it gets broken by this change?So I've been successful in getting in touch with this 3P app author, and they've already disabled their usage of anchor positioning generally. So that specific case should be handled. Generally, the behavior that will be broken by the rename is that fallback positions will not be attempted, meaning only the primary anchor position will be used.I think this rename is fairly safe, but I want to make sure that we're planning on shipping it with a flag that would be able to undo the behavior (a killswitch). I assume having two flags, one to add a new flag and one to remove the old flag is the easiest way to do that. WDYT?Thanks, I'm glad you agree that this should be relatively safe, if done *soon* before usage increases. And to confirm, we do have two flags (CSSPositionTryFallbacks and CSSPositionTryOptions) which work exactly as you suggest. We will flip flop their states, but retain the ability to swap that back via Finch in case of emergency.Thanks, Mason Thanks, Vlad /Gecko/: No signal /WebKit/: No signal /Web developers/: No signals /Other signals/: WebView application risks Does this intent deprecate or change behavior of existing APIs, such that it has potentially high risk for Android WebView-based applications? None Debuggability None Will this feature be supported on all six Blink platforms (Windows, Mac, Linux, ChromeOS, Android, and Android WebView)? Yes Is this feature fully tested by web-platform-tests <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md>? Yes https://wpt.fyi/results/css/css-anchor-position Flag name on chrome://flags None Finch feature name None Non-finch justification None Requires code in //chrome? False Tracking bug https://crbug.com/349600667 Estimated milestones Shipping on desktop 128 DevTrial on desktop 128 Shipping on Android 128 DevTrial on Android 128 Shipping on WebView 128 Anticipated spec changes Open questions about a feature may be a source of future web compat or interop issues. Please list open issues (e.g. links to known github issues in the project for the feature specification) whose resolution may introduce web compat/interop risk (e.g., changing to naming or structure of the API in a non-backward-compatible way). None Link to entry on the Chrome Platform Status https://chromestatus.com/feature/5090673808900096?gate=5938066895405056 This intent message was generated by Chrome Platform Status <https://chromestatus.com/>.-- You received this message because you are subscribed tothe Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAM%3DNeDj38gT4PfU4fCXhkdAOLvdY8c_sgukkotmHnC6wTZoDhQ%40mail.gmail.com <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAM%3DNeDj38gT4PfU4fCXhkdAOLvdY8c_sgukkotmHnC6wTZoDhQ%40mail.gmail.com?utm_medium=email&utm_source=footer>.-- You received this message because you are subscribed to theGoogle Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CADsXd2NGyhFn1y3e_8pr0f8X6emQBK6Kwi_KeatHrN4WN2VA3w%40mail.gmail.com <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CADsXd2NGyhFn1y3e_8pr0f8X6emQBK6Kwi_KeatHrN4WN2VA3w%40mail.gmail.com?utm_medium=email&utm_source=footer>. --You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAM%3DNeDjLeUUVCMdxfTswk0vVj2QAiqECsAaT%2B_kCGieiDsbxZA%40mail.gmail.com <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAM%3DNeDjLeUUVCMdxfTswk0vVj2QAiqECsAaT%2B_kCGieiDsbxZA%40mail.gmail.com?utm_medium=email&utm_source=footer>.
-- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/dfba05ae-c307-41a5-856d-26aa2840baa2%40gmail.com.
