LGTM1 This sounds like a web-exposed bug fix, and I agree that the risk seems low.
On Tue, Jun 11, 2024 at 6:10 PM 'Xiaochen Zhou' via blink-dev < blink-dev@chromium.org> wrote: > I have started the requests, thank you. This item was originated from a > previous launch: > https://chromestatus.com/feature/5140606359175168?gate=5143092244250624. > This feature was added to the Protected Audience explainer, but was never > implemented or spec'd. This launch implemented this missing feature and > added it to the spec. Please refer to the previous launch for reviews, > thank you. > > On Tuesday, June 11, 2024 at 11:36:28 AM UTC-4 vmp...@chromium.org wrote: > >> Hi, >> >> Can you please start the various reviews in chromestatus? >> [image: chipsna.png] >> >> Thanks, >> Vlad >> >> On Fri, Jun 7, 2024 at 11:10 AM 'Xiaochen Zhou' via blink-dev < >> blin...@chromium.org> wrote: >> >>> Contact emails >>> >>> xiaoc...@google.com, shiva...@google.com, jka...@google.com >>> >>> Explainer >>> >>> https://github.com/WICG/turtledove/pull/1145 >>> >>> Specification >>> >>> https://github.com/WICG/turtledove/pull/1141 >>> >>> Design docs >>> >>> >>> https://docs.google.com/document/d/1JSUZzEnVGn6Rz6ncLbyhThModoxTGnBn-jS5xJf4Aq0/edit?usp=sharing >>> >>> Summary >>> >>> We will complete the renderSize implementation to match what the >>> Protected Audience explainer claims >>> <https://github.com/WICG/turtledove/blob/main/FLEDGE.md#23-scoring-bids>. >>> The explainer states that if the Protected Audience generateBid function >>> returns a render URL with size specified, then the browserSignals argument >>> to the scoreAd function will have a renderSize field reflecting that size >>> (so that all relevant information about the bid is available for scoring). >>> However this was missed during implementation. >>> >>> Setting this field is unlikely to break existing usage as this field has >>> been a part of the explainer for 7 months and has always been optional. >>> renderSize is only passed into scoreAd(), as part of browserSignals, if >>> generateBid() returned a width and height. If it is specified, script can >>> check whether the fix is enabled by executing: >>> >>> 'renderSize' in browserSignals >>> >>> See Github issue <https://github.com/WICG/turtledove/issues/1088> and >>> explainer sections for renderSize >>> <https://github.com/WICG/turtledove/blob/main/FLEDGE.md#23-scoring-bids> >>> . >>> >>> Blink component >>> >>> Blink>InterestGroups >>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EInterestGroups> >>> >>> TAG review >>> >>> None >>> >>> TAG review status >>> >>> Not applicable >>> >>> Risks >>> >>> Interoperability and Compatibility >>> >>> None >>> >>> Gecko: No signal >>> >>> WebKit: No signal >>> >>> Web developers: No signals >>> >>> Other signals: >>> >>> WebView application risks >>> >>> Does this intent deprecate or change behavior of existing APIs, such >>> that it has potentially high risk for Android WebView-based applications? >>> >>> None >>> >>> >>> Debuggability >>> >>> Additional debugging capabilities are not necessary for these feature >>> changes. >>> >>> >>> Will this feature be supported on all six Blink platforms (Windows, Mac, >>> Linux, ChromeOS, Android, and Android WebView)? >>> >>> No >>> >>> Supported on all six Blink platforms except Android WebView. >>> >>> >>> Is this feature fully tested by web-platform-tests >>> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >>> ? >>> >>> Yes, it is tested by >>> third_party/blink/web_tests/external/wpt/fledge/tentative/score-ad-browser-signals.https.window.js. >>> >>> Flag name on chrome://flags >>> >>> None >>> >>> Finch feature name >>> >>> None >>> >> Please add a runtime flag with a base feature for this, just in case this turns out riskier than expected. > >>> Non-finch justification >>> >>> None >>> >>> Requires code in //chrome? >>> >>> False >>> >>> Tracking bug >>> >>> https://issues.chromium.org/u/1/issues/333628467 >>> >>> Launch bug >>> >>> https://launch.corp.google.com/launch/4319084 >>> >>> Estimated milestones >>> >>> No milestones specified >>> >>> >>> Anticipated spec changes >>> >>> Open questions about a feature may be a source of future web compat or >>> interop issues. Please list open issues (e.g. links to known github issues >>> in the project for the feature specification) whose resolution may >>> introduce web compat/interop risk (e.g., changing to naming or structure of >>> the API in a non-backward-compatible way). >>> >>> None >>> >>> Link to entry on the Chrome Platform Status >>> >>> https://chromestatus.com/feature/5181817440436224 >>> >>> This intent message was generated by Chrome Platform Status >>> <https://chromestatus.com/> >>> >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "blink-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to blink-dev+...@chromium.org. >>> To view this discussion on the web visit >>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CALrW-V%2BWeRpO5f%3D%3DyMvbHrQHqs_FFT-w0-aKm37UyTtoSgTULA%40mail.gmail.com >>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CALrW-V%2BWeRpO5f%3D%3DyMvbHrQHqs_FFT-w0-aKm37UyTtoSgTULA%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> >> -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/5a7e0a8c-3fc0-4a18-a705-be7da379aec3n%40chromium.org > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/5a7e0a8c-3fc0-4a18-a705-be7da379aec3n%40chromium.org?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOmohS%2Btrnus2c2LKeAYkmR0cHMwH4h-XhSM%2BF22XfVbZ4o%2B4w%40mail.gmail.com.
