Great! Thanks Chris! On Mon, Jun 3, 2024 at 2:00 PM Chris Harrelson <chris...@chromium.org> wrote:
> Hi Jiaming, > > 3 LGTMs are needed. So you're good to go! Happy shipping. > > On Mon, Jun 3, 2024 at 1:56 PM 'Jiaming Cheng' via blink-dev < > blink-dev@chromium.org> wrote: > >> Hi Team, >> >> Thanks all for the LGTMs! >> To clarify, how many LGTMs are typically required before we can enable >> this feature to stable? >> >> Best, >> Jiaming >> >> On Fri, May 31, 2024 at 6:31 AM Mike Taylor <miketa...@chromium.org> >> wrote: >> >>> LGTM3 >>> On 5/31/24 4:08 AM, Yoav Weiss (@Shopify) wrote: >>> >>> LGTM2 >>> >>> On Fri, May 31, 2024 at 5:52 AM 'Jiaming Cheng' via blink-dev < >>> blink-dev@chromium.org> wrote: >>> >>>> Thanks Domenic :] >>>> >>>> On Thu, May 30, 2024 at 6:28 PM Domenic Denicola <dome...@chromium.org> >>>> wrote: >>>> >>>>> LGTM1. >>>>> >>>>> This feature and its spec fits well with the existing MediaMetadata. >>>>> It has received a positive position from Mozilla. The TAG review solicited >>>>> a good discussion of considered alternatives. >>>>> >>>>> I agree with Alex that this would have gone better with a proper >>>>> explainer, including considered alternatives and example code. But the >>>>> feature is simple enough, and thankfully we got a chance to spell out the >>>>> reasoning about alternatives in the TAG review, so I think we can proceed. >>>>> >>>>> On Saturday, May 18, 2024 at 1:53:09 AM UTC+9 Alex Russell wrote: >>>>> >>>>>> Sorry for the slow reply here. >>>>>> >>>>>> Glad to see this works for Audio too. This might have been a bit more >>>>>> obvious of there were an explainer in the usual format. I expect the TAG >>>>>> will ask for one of those too. Please pay particular attention to >>>>>> considered alternatives and example code, both for the proposed design >>>>>> and >>>>>> for discarded alternatives. >>>>>> >>>>>> https://w3ctag.org/explainers/ >>>>>> >>>>>> Best, >>>>>> >>>>>> Alex >>>>>> >>>>>> On Wednesday, May 15, 2024 at 12:14:18 PM UTC-7 Jiaming Cheng wrote: >>>>>> >>>>>>> Thanks Domenic and Mike for the reply! >>>>>>> >>>>>>> I see. It looks like we have an LGTM on the Mozilla review >>>>>>> <https://github.com/mozilla/standards-positions/issues/1019>. Could >>>>>>> we please add some reviewers for the TAG review as well? If not, I'm >>>>>>> happy >>>>>>> to ping this thread again in two weeks :] >>>>>>> >>>>>>> Best, >>>>>>> Jiaming >>>>>>> >>>>>>> On Tue, May 14, 2024 at 10:16 PM Domenic Denicola < >>>>>>> dome...@chromium.org> wrote: >>>>>>> >>>>>>>> Hi Jiaming, >>>>>>>> >>>>>>>> Per our process >>>>>>>> <https://www.chromium.org/blink/launching-features/#new-feature-prepare-to-ship>, >>>>>>>> we give the TAG and other vendors at least one month to comment on >>>>>>>> changes. >>>>>>>> (This is why it is recommended to start these reviewers earlier, before >>>>>>>> sending the Intent to Ship.) So it might be a bit more time before we >>>>>>>> can >>>>>>>> consider this feature for shipping. Of course, if you get responses and >>>>>>>> engagement before that point, we can proceed earlier. >>>>>>>> >>>>>>>> -Domenic >>>>>>>> >>>>>>>> On Tuesday, May 14, 2024 at 11:06:55 AM UTC+9 Jiaming Cheng wrote: >>>>>>>> >>>>>>>>> Hi team, >>>>>>>>> >>>>>>>>> Those reviews have been posted for 10 days, there's no opposing >>>>>>>>> comments on any of them so far. Could you please take another look at >>>>>>>>> this >>>>>>>>> intent? >>>>>>>>> >>>>>>>>> Let me know if you have any further questions or concerns. >>>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> Jiaming >>>>>>>>> >>>>>>>>> On Fri, May 3, 2024 at 6:25 PM Jiaming Cheng <jiami...@google.com> >>>>>>>>> wrote: >>>>>>>>> >>>>>>>>>> Hi Alex, Chris and Daniel, >>>>>>>>>> >>>>>>>>>> Thank you for your valuable feedback! >>>>>>>>>> >>>>>>>>>> I've addressed your comments and taken the following updates: >>>>>>>>>> >>>>>>>>>> Hey Alex, the ChapterInformation *does* apply to audio as well >>>>>>>>>> as video, since MediaSession is for both audio and video. I've >>>>>>>>>> updated the >>>>>>>>>> Chrome status to reflect this. >>>>>>>>>> >>>>>>>>>> Additionally, I've taken the following actions: >>>>>>>>>> >>>>>>>>>> - Added WPT test: >>>>>>>>>> https://chromium-review.googlesource.com/c/chromium/src/+/5516503 >>>>>>>>>> >>>>>>>>>> - Filed TAG review: >>>>>>>>>> https://github.com/w3ctag/design-reviews/issues/952 >>>>>>>>>> - Filed WebKit review: >>>>>>>>>> https://github.com/WebKit/standards-positions/issues/344 >>>>>>>>>> - Filed Gecko review: >>>>>>>>>> https://github.com/mozilla/standards-positions/issues/1019 >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> I will keep you updated on the progress of these reviews and >>>>>>>>>> notify you once they are approved. Let me know if you have any >>>>>>>>>> questions :] >>>>>>>>>> >>>>>>>>>> Best, >>>>>>>>>> Jiaming >>>>>>>>>> >>>>>>>>>> On Wed, May 1, 2024 at 8:57 AM Alex Russell < >>>>>>>>>> slightly...@chromium.org> wrote: >>>>>>>>>> >>>>>>>>>>> Hey folks, >>>>>>>>>>> >>>>>>>>>>> On reviewing this, I'm concerned that this isn't also addressing >>>>>>>>>>> the same needs for Audio. This would have come up in a TAG review, >>>>>>>>>>> and >>>>>>>>>>> probably would have been fleshed out in an Explainer. Would like to >>>>>>>>>>> see >>>>>>>>>>> those before this progresses. >>>>>>>>>>> >>>>>>>>>>> Best, >>>>>>>>>>> >>>>>>>>>>> Alex >>>>>>>>>>> >>>>>>>>>>> On Tuesday, April 30, 2024 at 3:35:45 PM UTC-7 >>>>>>>>>>> dan...@microsoft.com wrote: >>>>>>>>>>> >>>>>>>>>>>> I was curious about WPT coverage for this and found >>>>>>>>>>>> https://wpt.fyi/results/mediasession/mediametadata.html >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Maybe that could be updated to check for the basics of the new >>>>>>>>>>>> attribute? >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> -- Dan >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> *From:* 'Jiaming Cheng' via blink-dev <blink-dev@chromium.org> >>>>>>>>>>>> *Sent:* Tuesday, April 30, 2024 1:50 PM >>>>>>>>>>>> *To:* blink-dev@chromium.org >>>>>>>>>>>> *Cc:* Alex Newcomer <newco...@google.com>; Megan Fu < >>>>>>>>>>>> megan...@google.com>; Tommy Steimel <stei...@google.com>; >>>>>>>>>>>> Andrew Xu <andre...@google.com> >>>>>>>>>>>> *Subject:* [blink-dev] Intent to Ship: Support Video Chapter >>>>>>>>>>>> in MediaMetadata >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Contact emails >>>>>>>>>>>> >>>>>>>>>>>> jiami...@google.com >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Explainer >>>>>>>>>>>> >>>>>>>>>>>> https://github.com/w3c/mediasession/pull/308 >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Specification >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> https://www.w3.org/TR/mediasession/#the-chapterinformation-interface >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Summary >>>>>>>>>>>> >>>>>>>>>>>> The corresponding implementation on the blink layer based on >>>>>>>>>>>> the w3c api change, which is to add the `ChapterInformation` >>>>>>>>>>>> attribute in >>>>>>>>>>>> the existing `MediaMetadata` See the propose: >>>>>>>>>>>> https://github.com/w3c/mediasession/issues/273 >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Blink component >>>>>>>>>>>> >>>>>>>>>>>> Blink>Media>Session >>>>>>>>>>>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EMedia%3ESession> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> TAG review >>>>>>>>>>>> >>>>>>>>>>>> None >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> TAG review status >>>>>>>>>>>> >>>>>>>>>>>> Not applicable >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Risks >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Interoperability and Compatibility >>>>>>>>>>>> >>>>>>>>>>>> It’s low risk as it's a small addition to an existing API that >>>>>>>>>>>> both Gecko and WebKit approve of >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> *Gecko*: No signal >>>>>>>>>>>> >>>>>>>>>>>> *WebKit*: No signal >>>>>>>>>>>> >>>>>>>>>>>> *Web developers*: No signals >>>>>>>>>>>> >>>>>>>>>>>> *Other signals*: >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> WebView application risks >>>>>>>>>>>> >>>>>>>>>>>> *Does this intent deprecate or change behavior of existing >>>>>>>>>>>> APIs, such that it has potentially high risk for Android >>>>>>>>>>>> WebView-based >>>>>>>>>>>> applications?* >>>>>>>>>>>> >>>>>>>>>>>> None >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Debuggability >>>>>>>>>>>> >>>>>>>>>>>> None >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Will this feature be supported on all six Blink platforms >>>>>>>>>>>> (Windows, Mac, Linux, ChromeOS, Android, and Android WebView)? >>>>>>>>>>>> >>>>>>>>>>>> No >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Is this feature fully tested by web-platform-tests >>>>>>>>>>>> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >>>>>>>>>>>> ? >>>>>>>>>>>> >>>>>>>>>>>> No >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Flag name on chrome://flags >>>>>>>>>>>> >>>>>>>>>>>> MediaSessionChapterInformation >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Finch feature name >>>>>>>>>>>> >>>>>>>>>>>> None >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Non-finch justification >>>>>>>>>>>> >>>>>>>>>>>> None >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Requires code in //chrome? >>>>>>>>>>>> >>>>>>>>>>>> False >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Sample links >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> https://googlechrome.github.io/samples/media-session/video.html >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Estimated milestones >>>>>>>>>>>> >>>>>>>>>>>> Shipping on desktop >>>>>>>>>>>> >>>>>>>>>>>> 126 >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Anticipated spec changes >>>>>>>>>>>> >>>>>>>>>>>> *Open questions about a feature may be a source of future web >>>>>>>>>>>> compat or interop issues. Please list open issues (e.g. links to >>>>>>>>>>>> known >>>>>>>>>>>> github issues in the project for the feature specification) whose >>>>>>>>>>>> resolution may introduce web compat/interop risk (e.g., changing >>>>>>>>>>>> to naming >>>>>>>>>>>> or structure of the API in a non-backward-compatible way).* >>>>>>>>>>>> >>>>>>>>>>>> None >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Link to entry on the Chrome Platform Status >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> https://chromestatus.com/feature/6682585059295232?gate=5003115407605760 >>>>>>>>>>>> >>>>>>>>>>>> This intent message was generated by Chrome Platform Status >>>>>>>>>>>> <https://chromestatus.com/>. >>>>>>>>>>>> >>>>>>>>>>>> -- >>>>>>>>>>>> You received this message because you are subscribed to the >>>>>>>>>>>> Google Groups "blink-dev" group. >>>>>>>>>>>> To unsubscribe from this group and stop receiving emails from >>>>>>>>>>>> it, send an email to blink-dev+unsubscr...@chromium.org. >>>>>>>>>>>> To view this discussion on the web visit >>>>>>>>>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CABE8buQTGirUaRRsr9ooud9S%3Dg0OquQy6rGy%2BvnrDtT7T%2BqK%2BQ%40mail.gmail.com >>>>>>>>>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CABE8buQTGirUaRRsr9ooud9S%3Dg0OquQy6rGy%2BvnrDtT7T%2BqK%2BQ%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>>>>>>>>>> . >>>>>>>>>>>> >>>>>>>>>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "blink-dev" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to blink-dev+unsubscr...@chromium.org. >>>> To view this discussion on the web visit >>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CABE8buRO0uw_Z_tj_nvwYG_Gt5tGG-h0C_qu%3Dv%3DeN6hFfsqj9g%40mail.gmail.com >>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CABE8buRO0uw_Z_tj_nvwYG_Gt5tGG-h0C_qu%3Dv%3DeN6hFfsqj9g%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>> . >>>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "blink-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to blink-dev+unsubscr...@chromium.org. >>> To view this discussion on the web visit >>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOmohSK91fMAuNjRm5%3Dgz3Dzs-mWQeoBMrPSLErPs0J4MmFrdg%40mail.gmail.com >>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOmohSK91fMAuNjRm5%3Dgz3Dzs-mWQeoBMrPSLErPs0J4MmFrdg%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> >>> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to blink-dev+unsubscr...@chromium.org. >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CABE8buTu1D-bv6jDFoRURjH1tTNrmnbOrKzo%2BVOX1_L87WMBjQ%40mail.gmail.com >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CABE8buTu1D-bv6jDFoRURjH1tTNrmnbOrKzo%2BVOX1_L87WMBjQ%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CABE8buS0X-OF9PQus7Gtw5pd6HOQ8ZS-UBRxvHho_D-FVF3K%2Bw%40mail.gmail.com.
