On Tue, May 21, 2024 at 2:20 PM Joey Arhar <[email protected]> wrote:
> > Do you know what the breakage looks like > > I pushed to make sure that using the old syntax with CustomStateSet.add() > wouldn't throw exceptions when in the new mode in order to reduce breakage. > When websites use the old syntax after it's removed, they will just have > styling differences because their selectors won't parse anymore. > > > or whether this usage is limited to a library/a small set of large > websites or something else? > > Based on the analysis that I linked in the previous thread > <https://docs.google.com/document/d/1BHoO12ts0E-NQQH9AMwR2sKAIV0OPB-FA_8QXMpolz0/edit>, > there are some websites which all look very similar which use it, but they > are all hidden behind display:none elements that I had to manually reveal. > There was only one website I found which was actually using it which has a > carousel which has buttons that didn't work in safari and firefox because > CustomStateSet didn't exist yet. > > I don't think there is a popular library which is using the deprecated > syntax. > > > Ideally, this is feature detected with some fallback syntax > > Websites just have to replace ":--foo" with ":state(foo)", I don't think > any feature detection is necessary. If they are interested in supporting > older browsers, then I don't see why they would have any interest in > looking at whether the deprecated syntax works or not because the other > browsers didn't have it before and neither did we until a couple years ago. > I meant I hope that existing use is either feature-detected or it's using both properties. In either case, it's very easy to fix if problems arise since alternate syntax is shipped already in multiple browsers. LGTM1 > On Tue, May 21, 2024 at 11:09 AM Vladimir Levin <[email protected]> wrote: > >> Hey, >> >> 0.04% seems like a fairly sizable number. Do you know what the breakage >> looks like or whether this usage is limited to a library/a small set of >> large websites or something else? >> >> Ideally, this is feature detected with some fallback syntax >> >> >> On Tue, May 21, 2024 at 1:39 PM Joey Arhar <[email protected]> wrote: >> >>> Contact [email protected] >>> >>> ExplainerNone >>> >>> Specificationhttps://github.com/whatwg/html/pull/8467 >>> >>> Summary >>> >>> The CSS custom state pseudo-class is being renamed from :--foo to >>> :state(foo). The new syntax, :state(foo), has been enabled by default, and >>> now we have to deprecate and remove the :--foo syntax. Gecko and webkit >>> never implemented the old syntax and they have both shipped the new syntax. >>> We are currently shipping both the new syntax and the old syntax at the >>> same time. There have been console errors and DevTools deprecations for the >>> old syntax for many milestones already. Previous thread on this topic: >>> https://groups.google.com/a/chromium.org/g/blink-dev/c/JvpHoUfhJYE/m/uRtWiqoHAQAJ >>> The UseCounter is currently at 0.04% >>> https://chromestatus.com/metrics/feature/timeline/popularity/3796 >>> >>> >>> Blink componentBlink>HTML>CustomElements >>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EHTML%3ECustomElements> >>> >>> Motivation >>> >>> The syntax of this feature needs to change in order to get support from >>> the other browsers and eventually have interoperable behavior. >>> >>> >>> Initial public proposalNone >>> >>> TAG reviewNone >>> >>> TAG review statusNot applicable >>> >>> Risks >>> >>> >>> Interoperability and Compatibility >>> >>> Websites which are currently using the old syntax and don't migrate to >>> the new syntax will have CSS selectors which become invalid which would >>> impact the styling of their custom elements. >>> >>> >>> *Gecko*: Positive Firefox has shipped the new syntax >>> >>> *WebKit*: Positive ( >>> https://github.com/whatwg/html/pull/8467#issuecomment-1381645661) >>> Safari has shipped the new syntax >>> >>> *Web developers*: No signals >>> >>> *Other signals*: >>> >>> Activation >>> >>> Switching to the new syntax is easy. >>> >>> >>> WebView application risks >>> >>> Does this intent deprecate or change behavior of existing APIs, such >>> that it has potentially high risk for Android WebView-based applications? >>> >>> None >>> >>> >>> Debuggability >>> >>> None >>> >>> >>> Is this feature fully tested by web-platform-tests >>> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >>> ?Yes >>> >>> https://wpt.fyi/results/custom-elements/state >>> >>> >>> Flag name on chrome://flagsNone >>> >>> Finch feature nameCSSCustomStateDeprecatedSyntax >>> >>> Requires code in //chrome?False >>> >>> Tracking bughttps://issues.chromium.org/issues/41486953 >>> >>> Estimated milestones >>> >>> No milestones specified >>> >>> >>> Link to entry on the Chrome Platform Status >>> https://chromestatus.com/feature/5140610730426368?gate=4940354997714944 >>> >>> Links to previous Intent discussions >>> https://groups.google.com/a/chromium.org/g/blink-dev/c/JvpHoUfhJYE/m/uRtWiqoHAQAJ >>> >>> This intent message was generated by Chrome Platform Status >>> <https://chromestatus.com/>. >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "blink-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To view this discussion on the web visit >>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAK6btwKTMe%3DDOHsX%2Bs6PH%2BO6w0sJ7ZtS6jL%2BGV%2B958ZXLux_Ew%40mail.gmail.com >>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAK6btwKTMe%3DDOHsX%2Bs6PH%2BO6w0sJ7ZtS6jL%2BGV%2B958ZXLux_Ew%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> >> -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAK6btwLgrD%3DJp9F%2Bn0yw5HjYFyM3k0NckpuXZn%3DjA3Fri8L9Rw%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAK6btwLgrD%3DJp9F%2Bn0yw5HjYFyM3k0NckpuXZn%3DjA3Fri8L9Rw%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CADsXd2POX7A_BH14CXttoB9oj6EoQy4j%2BpXoK1fFLNU-bh8Lfg%40mail.gmail.com.
