LGTM3

On Tue, Feb 20, 2024 at 1:03 PM Yoav Weiss (@Shopify) <
yoavwe...@chromium.org> wrote:

> LGTM2
>
> On Tue, Feb 20, 2024 at 8:50 PM Rick Byers <rby...@chromium.org> wrote:
>
>> Looks pretty straightforward to me and has some good support from other
>> engines. LGTM1
>>
>> /cc @Mathias Bynens <m...@google.com> in case he has any thoughts from a
>> WebDriver perspective
>>
>>
>> On Wed, Feb 14, 2024 at 6:21 PM Nina Satragno <nsatra...@chromium.org>
>> wrote:
>>
>>> Contact emails
>>>
>>> nsatra...@chromium.org, chrome-webau...@google.com
>>>
>>> Specification
>>>
>>> https://w3c.github.io/webauthn/#sctn-automation, look for backupState
>>> and backupEligibility
>>>
>>>
>>> Or, if you prefer, see the merged PR
>>> <https://github.com/w3c/webauthn/pull/1999>.
>>>
>>> Summary
>>>
>>> A set of new attributes for WebAuthn WebDriver Virtual Authenticators
>>> <https://w3c.github.io/webauthn/#sctn-automation-virtual-authenticators>
>>> and their Credential Parameters
>>> <https://w3c.github.io/webauthn/#sctn-automation-add-credential> that
>>> allow setting default and current values for the backup state
>>> <https://w3c.github.io/webauthn/#backup-state> and backup eligibility
>>> <https://w3c.github.io/webauthn/#backup-eligibility> credential flags,
>>> and a new Set Credential Properties
>>> <https://w3c.github.io/webauthn/#sctn-automation-set-credential-properties>
>>> command that lets developers manipulate these values for existing (virtual)
>>> credentials. The motivation is to allow developers to write integration
>>> tests that exercise a web application reacting to backup state changes as
>>> real credentials would during their lifetime.
>>>
>>> The feature is already implemented at the devtools level, we are
>>> requesting permission to implement and ship its WebDriver layer.
>>>
>>> Blink component
>>>
>>> Blink>WebAuthn
>>>
>>> TAG review
>>>
>>> N/A
>>>
>>> Risks
>>>
>>> Interoperability and Compatibility
>>>
>>> Firefox and Safari support the WebAuthn WebDriver API. However, Chrome
>>> is the first to implement backup flags settings.
>>>
>>> Gecko: No signals.
>>>
>>> WebKit: pascoej@ (Apple) reviewed & approved the PR.
>>>
>>> Web developers: MasterKale@ (Duo / Cisco) showed support & approved the
>>> PR
>>> <https://github.com/w3c/webauthn/pull/1999#pullrequestreview-1743243572>
>>> .
>>>
>>> Other signals: emlun@ (Yubico) also approved the PR.
>>>
>>> WebView application risks
>>>
>>> Does this intent deprecate or change behavior of existing APIs, such
>>> that it has potentially high risk for Android WebView-based applications?
>>>
>>> The virtual authenticator is not supported on webviews.
>>>
>>> Ergonomics
>>>
>>> N/A
>>>
>>> ActivationDevelopers will be able to connect to the browser through the
>>> WebDriver API as specified, or use Selenium bindings.
>>> Security
>>>
>>> This is only exposed through WebDriver.
>>>
>>>
>>> Debuggability
>>>
>>> This is a debugging feature.
>>>
>>> Will this feature be supported on all six Blink platforms (Windows, Mac,
>>> Linux, ChromeOS, Android, and Android WebView)?
>>>
>>> No. The WebAuthn WebDriver API is only available on desktop.
>>>
>>> Is this feature fully tested by web-platform-tests
>>> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md>
>>> ?
>>>
>>> No. This is not a web feature.
>>>
>>> DevTrial instructions
>>>
>>> The WebDriver layer is not implemented yet. Developers wishing to try
>>> the underlying API can access it directly through Chrome's DevTools
>>> Protocol
>>> <https://chromedevtools.github.io/devtools-protocol/tot/WebAuthn/#method-setCredentialProperties>
>>> .
>>>
>>> Flag name on chrome://flags
>>>
>>> N/A
>>>
>>> Finch feature name
>>>
>>> N/A
>>>
>>> Non-finch justification
>>>
>>> WebDriver feature.
>>>
>>> Requires code in //chrome?
>>>
>>> False
>>>
>>> Tracking bug
>>>
>>> crbug.com/40945430
>>>
>>> Launch bug
>>>
>>> crbug.com/40945430
>>>
>>> Estimated milestones
>>>
>>> M124.
>>>
>>>
>>> --
>>> Nina Satragno
>>>
>>> --
>>> You received this message because you are subscribed to the Google
>>> Groups "blink-dev" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to blink-dev+unsubscr...@chromium.org.
>>> To view this discussion on the web visit
>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAB0jio%3DMgFH%2BurT0jeM66dvBwJZFq3LoZiUUndmgccO%3DRzNBbg%40mail.gmail.com
>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAB0jio%3DMgFH%2BurT0jeM66dvBwJZFq3LoZiUUndmgccO%3DRzNBbg%40mail.gmail.com?utm_medium=email&utm_source=footer>
>>> .
>>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "blink-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to blink-dev+unsubscr...@chromium.org.
>> To view this discussion on the web visit
>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY9QYnbo0x-tqpb8mQDju2jgOZjuefRgjLKRdVziz94Jyg%40mail.gmail.com
>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY9QYnbo0x-tqpb8mQDju2jgOZjuefRgjLKRdVziz94Jyg%40mail.gmail.com?utm_medium=email&utm_source=footer>
>> .
>>
> --
> You received this message because you are subscribed to the Google Groups
> "blink-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to blink-dev+unsubscr...@chromium.org.
> To view this discussion on the web visit
> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOmohSJyZ%2BYH8k_bUYL2NVTAwRs4BTT1AhmGmTaAMMY1sMsQJg%40mail.gmail.com
> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOmohSJyZ%2BYH8k_bUYL2NVTAwRs4BTT1AhmGmTaAMMY1sMsQJg%40mail.gmail.com?utm_medium=email&utm_source=footer>
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw919sKO%3DN3FKGv%2BJymqY%3DRoT%2B4NL%3DUHqvvnt-ZAX0_i_w%40mail.gmail.com.

Reply via email to