Thanks for adding the test. LGTM2. Cheers, Rego
On 14/02/2024 13:15, 'François Beaufort' via blink-dev wrote:
On Wed, Feb 14, 2024 at 10:48 AM Manuel Rego Casasnovas <r...@igalia.com <mailto:r...@igalia.com>> wrote:On 14/02/2024 10:46, François Beaufort wrote: > > > On Wed, Feb 14, 2024 at 10:43 AM Manuel Rego Casasnovas <r...@igalia.com <mailto:r...@igalia.com> > <mailto:r...@igalia.com <mailto:r...@igalia.com>>> wrote: > > Hi, > > On 13/02/2024 11:13, 'François Beaufort' via blink-dev wrote: > > > > Is this feature fully tested by web-platform-tests > >> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md>>>?> > > > Yes > > > > https://wpt.fyi/results/css/mediaqueries/display-mode.html <https://wpt.fyi/results/css/mediaqueries/display-mode.html> > <https://wpt.fyi/results/css/mediaqueries/display-mode.html <https://wpt.fyi/results/css/mediaqueries/display-mode.html>> > > <https://wpt.fyi/results/css/mediaqueries/display-mode.html <https://wpt.fyi/results/css/mediaqueries/display-mode.html> > <https://wpt.fyi/results/css/mediaqueries/display-mode.html <https://wpt.fyi/results/css/mediaqueries/display-mode.html>>> > > https://wpt.live/css/mediaqueries/display-mode.html <https://wpt.live/css/mediaqueries/display-mode.html> > <https://wpt.live/css/mediaqueries/display-mode.html <https://wpt.live/css/mediaqueries/display-mode.html>> > > <https://wpt.live/css/mediaqueries/display-mode.html <https://wpt.live/css/mediaqueries/display-mode.html> > <https://wpt.live/css/mediaqueries/display-mode.html <https://wpt.live/css/mediaqueries/display-mode.html>>> > > Is this only testing the parsing of the new value? > > > These ones only do that. > > We have chromium browser tests for this at > https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/picture_in_picture/document_picture_in_picture_window_controller_browsertest.cc;l=781;drc=feec59141dfbef0543100614b568f2b8f7e71af1 <https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/picture_in_picture/document_picture_in_picture_window_controller_browsertest.cc;l=781;drc=feec59141dfbef0543100614b568f2b8f7e71af1> <https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/picture_in_picture/document_picture_in_picture_window_controller_browsertest.cc;l=781;drc=feec59141dfbef0543100614b568f2b8f7e71af1 <https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/picture_in_picture/document_picture_in_picture_window_controller_browsertest.cc;l=781;drc=feec59141dfbef0543100614b568f2b8f7e71af1>> Is there any WPT limitation preventing us for testing this there? If so we should report a WPT issue. Having behavioral tests in WPT is always useful to ensure interoperability in the future. I'm adding tests in WPT as suggested.See https://chromium-review.googlesource.com/c/chromium/src/+/5290634/3/third_party/blink/web_tests/external/wpt/document-picture-in-picture/display-mode.https.html <https://chromium-review.googlesource.com/c/chromium/src/+/5290634/3/third_party/blink/web_tests/external/wpt/document-picture-in-picture/display-mode.https.html>Thank you for catching! Cheers, Rego --You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org <mailto:blink-dev+unsubscr...@chromium.org>. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAPpwU5%2B-ajZwj01sZ3TOHADOwFd04FLoF0Zk7bF4Ow--riK6OA%40mail.gmail.com <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAPpwU5%2B-ajZwj01sZ3TOHADOwFd04FLoF0Zk7bF4Ow--riK6OA%40mail.gmail.com?utm_medium=email&utm_source=footer>.
-- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/3c37cf6d-0419-4dd6-ac8a-b3cae2dbee2c%40igalia.com.
