LGTM3 On Wed, Jan 3, 2024 at 6:44 PM Mike Taylor <[email protected]> wrote:
> No concerns. LGTM2 > On 1/3/24 1:41 PM, Chris Harrelson wrote: > > LGTM1 > > On Wed, Jan 3, 2024 at 5:05 AM Orr Bernstein <[email protected]> wrote: > >> Hi all, >> >> Thank you for your guidance here. I've updated the chromestatus entry to >> reflect the aforementioned delta, noting that the HTTP response header >> processing involved in this feature will work for both Fetch and iframe >> navigations. Both the explainer ( >> https://github.com/WICG/turtledove/pull/887) and spec ( >> https://github.com/WICG/turtledove/pull/918) changes to reflect that >> delta have been merged. When you have a chance, could you please take a >> look? Thank you again! >> >> All the best, >> - Orr >> >> On Wednesday, November 8, 2023 at 3:13:36 PM UTC-5 Chris Harrelson wrote: >> >>> If you want to batch it together that sounds fine to me. Can you: >>> >>> * Update the chromestatus entry >>> <https://chromestatus.com/feature/5021508157571072> accordingly >>> (including shipping milestones, updated description, and >>> potentially re-review of privacy security etc) >>> * Land those two PRs for the spec and explainer >>> >>> Then the API owners can review again and re-issue 3 new LGTMs if it >>> looks good. >>> >>> On Wed, Nov 8, 2023 at 11:47 AM 'Orr Bernstein' via blink-dev < >>> [email protected]> wrote: >>> >>>> Hi Chris, >>>> >>>> Thanks so much for the quick response. We have not yet shipped the >>>> negative targeting work. The absence of these additional changes means that >>>> some of the potential adopters of negative targeting can't do so, and so I >>>> was indeed proposing to batch these additional changes together with >>>> negative targeting. Would you recommend a new I2S and chromestatus entry? >>>> Thanks again. >>>> >>>> All the best, >>>> - Orr >>>> >>>> >>>> On Wednesday, November 8, 2023 at 1:37:19 PM UTC-5 Chris Harrelson >>>> wrote: >>>> >>>>> Hi Orr, >>>>> >>>>> Have you already shipped the negative targeting work? Or are you >>>>> proposing to batch these additional changes together with that, and >>>>> consider these new changes thematically related? If not, I think it would >>>>> be more clear to make a new I2S and chromestatus entry. >>>>> >>>>> On Wed, Nov 8, 2023 at 9:58 AM 'Orr Bernstein' via blink-dev < >>>>> [email protected]> wrote: >>>>> >>>>>> Hi all, >>>>>> >>>>>> We have a small delta to this feature we'd like to implement. In our >>>>>> current design, ad techs need to provide a flag, `adAuctionHeaders` on >>>>>> their `fetch()` request. ( >>>>>> https://github.com/WICG/turtledove/blob/main/FLEDGE.md#63-http-response-headers) >>>>>> However, we received feedback that some ad techs use iframe navigation >>>>>> instead of a `fetch()`. ( >>>>>> https://github.com/WICG/turtledove/issues/319#issuecomment-1766815150) >>>>>> To enable those ad techs to use this feature, we'd like to minimally >>>>>> extend >>>>>> our design to allow those that use iframe navigation to specify an >>>>>> `adAuctionHeaders` attribute on the iframe element that behaves the same >>>>>> as >>>>>> the `adAuctionHeaders` flag on `fetch()` requests. >>>>>> >>>>>> For more details, please see the PRs we've prepared for the spec - >>>>>> https://github.com/WICG/turtledove/pull/883 - and the explainer - >>>>>> https://github.com/WICG/turtledove/pull/887. >>>>>> >>>>>> Could you please review and provide LGTMs to ship this delta? Thank >>>>>> you so much! >>>>>> >>>>>> All the best, >>>>>> - Orr >>>>>> >>>>>> On Friday, October 20, 2023 at 12:06:12 PM UTC-4 Orr Bernstein wrote: >>>>>> >>>>>>> FYI, the spec (https://github.com/WICG/turtledove/pull/796) has >>>>>>> been merged. Thank you all again. >>>>>>> >>>>>>> All the best, >>>>>>> - Orr >>>>>>> >>>>>>> On Wednesday, October 4, 2023 at 3:04:23 PM UTC-4 Orr Bernstein >>>>>>> wrote: >>>>>>> >>>>>>>> Thank you all so much. I'll update this thread when >>>>>>>> https://github.com/WICG/turtledove/pull/796 has landed. >>>>>>>> >>>>>>>> All the best, >>>>>>>> - Orr >>>>>>>> >>>>>>>> >>>>>>>> On Wed, Oct 4, 2023 at 11:51 AM Chris Harrelson < >>>>>>>> [email protected]> wrote: >>>>>>>> >>>>>>>>> LGTM3, same. >>>>>>>>> >>>>>>>>> On Wed, Oct 4, 2023 at 8:50 AM Yoav Weiss <[email protected]> >>>>>>>>> wrote: >>>>>>>>> >>>>>>>>>> LGTM2 with the same conditions >>>>>>>>>> >>>>>>>>>> On Monday, October 2, 2023 at 11:00:07 PM UTC+2 Mike Taylor wrote: >>>>>>>>>> >>>>>>>>>>> LGTM1 % landing https://github.com/WICG/turtledove/pull/796. >>>>>>>>>>> Please follow up with the WPTs as well. >>>>>>>>>>> On 9/27/23 11:56 AM, Chris Harrelson wrote: >>>>>>>>>>> >>>>>>>>>>> Please fill out the other chromestatus review categories >>>>>>>>>>> (privacy, security, etc); we'll re-review once those are done. >>>>>>>>>>> >>>>>>>>>>> On Wed, Sep 20, 2023 at 2:42 PM 'Orr Bernstein' via blink-dev < >>>>>>>>>>> [email protected]> wrote: >>>>>>>>>>> >>>>>>>>>>>> Contact emails >>>>>>>>>>>> >>>>>>>>>>>> [email protected], [email protected] >>>>>>>>>>>> >>>>>>>>>>>> Explainer >>>>>>>>>>>> >>>>>>>>>>>> https://github.com/WICG/turtledove/pull/780 >>>>>>>>>>>> >>>>>>>>>>>> Specification >>>>>>>>>>>> >>>>>>>>>>>> https://github.com/WICG/turtledove/pull/796 >>>>>>>>>>>> >>>>>>>>>>>> Summary >>>>>>>>>>>> >>>>>>>>>>>> In online ad auctions for ad space, it’s sometimes useful to >>>>>>>>>>>> prevent showing an ad to certain audiences, a concept known as >>>>>>>>>>>> negative >>>>>>>>>>>> targeting. For example, you might not want to show a new customer >>>>>>>>>>>> advertisement to existing customers. New customer acquisition >>>>>>>>>>>> campaigns >>>>>>>>>>>> most often have this as a critical requirement. Protected Audience >>>>>>>>>>>> currently enables ads to target users that have been joined to a >>>>>>>>>>>> given >>>>>>>>>>>> interest group through some past activity on the web. This feature >>>>>>>>>>>> extends >>>>>>>>>>>> Protected Audience to enable negative targeting by allowing new >>>>>>>>>>>> ads to >>>>>>>>>>>> target only those users who have not been joined to a given >>>>>>>>>>>> interest group. >>>>>>>>>>>> In this way, we're enabling advertisers to target new groups of >>>>>>>>>>>> users using >>>>>>>>>>>> the existing privacy-preserving concepts of the Protected Audience >>>>>>>>>>>> API. >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Blink component >>>>>>>>>>>> >>>>>>>>>>>> Blink>InterestGroups >>>>>>>>>>>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EInterestGroups> >>>>>>>>>>>> >>>>>>>>>>>> TAG review >>>>>>>>>>>> >>>>>>>>>>>> The parent proposal, Protected Audience, is still pending: >>>>>>>>>>>> https://github.com/w3ctag/design-reviews/issues/723 >>>>>>>>>>>> >>>>>>>>>>>> TAG review status >>>>>>>>>>>> >>>>>>>>>>>> Pending >>>>>>>>>>>> >>>>>>>>>>>> Risks >>>>>>>>>>>> >>>>>>>>>>>> Interoperability and Compatibility >>>>>>>>>>>> >>>>>>>>>>>> None. This is an optional new feature of the Protected Audience >>>>>>>>>>>> API. Ad techs can use this new feature by specifying values for >>>>>>>>>>>> new fields >>>>>>>>>>>> in the auction config. Without explicit values for those new >>>>>>>>>>>> fields, >>>>>>>>>>>> there's no functional behavioral change as a result of this >>>>>>>>>>>> feature. >>>>>>>>>>>> >>>>>>>>>>>> Gecko & WebKit: No signal on parent proposal, Protected >>>>>>>>>>>> Audience. Asked in the Mozilla forum here >>>>>>>>>>>> <https://github.com/mozilla/standards-positions/issues/770>, >>>>>>>>>>>> and in the Webkit forum here >>>>>>>>>>>> <https://github.com/WebKit/standards-positions/issues/158>. >>>>>>>>>>>> >>>>>>>>>>>> Web developers: Adtech asked for this via Protected Audience >>>>>>>>>>>> Github issue #319 >>>>>>>>>>>> <https://github.com/WICG/turtledove/issues/319>. >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Debuggability >>>>>>>>>>>> >>>>>>>>>>>> Additional bids sent into the auction are visible in their >>>>>>>>>>>> response headers via DevTools. You can determine if the additional >>>>>>>>>>>> bid was >>>>>>>>>>>> sent for scoring by adding a breakpoint in the scoring script in >>>>>>>>>>>> DevTools. >>>>>>>>>>>> Error scenarios, e.g. signature verification errors and joining >>>>>>>>>>>> origin >>>>>>>>>>>> mismatch on negative interest groups - are written to the console. >>>>>>>>>>>> We're >>>>>>>>>>>> considering additional DevTools enhancements to aid additional bids >>>>>>>>>>>> debugging. >>>>>>>>>>>> >>>>>>>>>>>> Will this feature be supported on all six Blink platforms >>>>>>>>>>>> (Windows, Mac, Linux, Chrome OS, Android, and Android WebView)? >>>>>>>>>>>> >>>>>>>>>>>> It will be supported on all platforms that support Protected >>>>>>>>>>>> Audience, so all but WebView. >>>>>>>>>>>> >>>>>>>>>>>> Is this feature fully tested by web-platform-tests >>>>>>>>>>>> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >>>>>>>>>>>> ? >>>>>>>>>>>> >>>>>>>>>>>> We plan to add WPTs to cover this API in the next month. >>>>>>>>>>>> >>>>>>>>>>>> Flag name on chrome://flags >>>>>>>>>>>> >>>>>>>>>>>> None >>>>>>>>>>>> >>>>>>>>>>>> Finch feature name >>>>>>>>>>>> >>>>>>>>>>>> FledgeNegativeTargeting >>>>>>>>>>>> >>>>>>>>>>>> Requires code in //chrome? >>>>>>>>>>>> >>>>>>>>>>>> False >>>>>>>>>>>> >>>>>>>>>>>> Estimated milestones >>>>>>>>>>>> >>>>>>>>>>>> Shipping on desktop and Android in M118. >>>>>>>>>>>> >>>>>>>>>>>> Anticipated spec changes >>>>>>>>>>>> >>>>>>>>>>>> None related to this feature. >>>>>>>>>>>> >>>>>>>>>>>> Link to entry on the Chrome Platform Status >>>>>>>>>>>> >>>>>>>>>>>> https://chromestatus.com/feature/5021508157571072 >>>>>>>>>>>> >>>>>>>>>>>> This intent message was generated by Chrome Platform Status >>>>>>>>>>>> <https://chromestatus.com/>. >>>>>>>>>>>> -- >>>>>>>>>>>> You received this message because you are subscribed to the >>>>>>>>>>>> Google Groups "blink-dev" group. >>>>>>>>>>>> To unsubscribe from this group and stop receiving emails from >>>>>>>>>>>> it, send an email to [email protected]. >>>>>>>>>>>> To view this discussion on the web visit >>>>>>>>>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/5ebd44f6-57b2-448f-b32c-87d63acfa471n%40chromium.org >>>>>>>>>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/5ebd44f6-57b2-448f-b32c-87d63acfa471n%40chromium.org?utm_medium=email&utm_source=footer> >>>>>>>>>>>> . >>>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> You received this message because you are subscribed to the >>>>>>>>>>> Google Groups "blink-dev" group. >>>>>>>>>>> To unsubscribe from this group and stop receiving emails from >>>>>>>>>>> it, send an email to [email protected]. >>>>>>>>>>> >>>>>>>>>>> To view this discussion on the web visit >>>>>>>>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw_AJmJko%2BzZZLxD%2BN4db5aZzaJ3T%3D7OH0NFLjALxeQm1A%40mail.gmail.com >>>>>>>>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw_AJmJko%2BzZZLxD%2BN4db5aZzaJ3T%3D7OH0NFLjALxeQm1A%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>>>>>>>>> . >>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>> You received this message because you are subscribed to the >>>>>>>>>> Google Groups "blink-dev" group. >>>>>>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>>>>>> send an email to [email protected]. >>>>>>>>>> To view this discussion on the web visit >>>>>>>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/995abbf0-3a75-40a8-a8cb-4a9491662acfn%40chromium.org >>>>>>>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/995abbf0-3a75-40a8-a8cb-4a9491662acfn%40chromium.org?utm_medium=email&utm_source=footer> >>>>>>>>>> . >>>>>>>>>> >>>>>>>>> -- >>>>>> You received this message because you are subscribed to the Google >>>>>> Groups "blink-dev" group. >>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>> send an email to [email protected]. >>>>>> >>>>> To view this discussion on the web visit >>>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/440bdd0c-dcd3-4770-9b69-853dd1e2fa37n%40chromium.org >>>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/440bdd0c-dcd3-4770-9b69-853dd1e2fa37n%40chromium.org?utm_medium=email&utm_source=footer> >>>>>> . >>>>>> >>>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "blink-dev" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected]. >>>> >>> To view this discussion on the web visit >>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/01336528-96c6-4963-a97c-1c274f81d243n%40chromium.org >>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/01336528-96c6-4963-a97c-1c274f81d243n%40chromium.org?utm_medium=email&utm_source=footer> >>>> . >>>> >>> -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/c1ff7fae-a577-4452-9477-51b7908cc9b2%40chromium.org > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/c1ff7fae-a577-4452-9477-51b7908cc9b2%40chromium.org?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY9pUq24w-JSfjrOCjedvzmpRZjWUOX6tRMf%3D-H431RU9A%40mail.gmail.com.
