LGTM3 On Sun, Nov 26, 2023 at 3:09 AM Mike Taylor <miketa...@chromium.org> wrote:
> LGTM2 > On 11/23/23 8:39 AM, Yoav Weiss wrote: > > LGTM1 assuming there aren't any surprises on that front. Thanks!! > > On Thu, Nov 23, 2023 at 2:33 PM Dominik Röttsches <dr...@google.com> > wrote: > >> Hi Yoav, >> >> On Wed, Nov 22, 2023 at 6:46 PM Yoav Weiss <yoavwe...@chromium.org> >> wrote: >> >>> https://github.com/w3c/csswg-drafts/issues/8922#issuecomment-1720930646 >>> indicates that some parts of this were resolved and other parts are still >>> to be bikeshedded. >>> >>> Can you expand on that? What's the issue around color space >>> interpolation? >>> >> >> In my response further down in the thread I untangled that >> <https://github.com/w3c/csswg-drafts/issues/8922#issuecomment-1792237695>. >> There are two situations in which we need an explicit color space >> representation: >> 1) In mixing two palettes, to describe it as a static state, when an >> animation or transition has completed or when we're describing an interim >> state of an animation or transition. For this, we need an explicit >> interpolation method in the grammar of palette-mix() - to be consistent >> with color-mix() and to prepare to capture a static interpolation value >> when animations will have color space control, see below. >> The "remaining bike shedding to be done" that's captured in the notes >> solely originated from a question from emilio@ on whether that color >> interpolation tag is needed. Munira and I discussed that with him in the >> directly follow break at resolution at TPAC - but that was offline and not >> minuted. I am expecting emilio@ to comment on this - otherwise there was >> nothing open. >> >> 2) What needs to be discussed as a wider issue in CSS is controlling the >> interpolation method during animation or transitions, but that's outside >> the scope of the issue we resolved on. Interpolation color space control >> during animations and transitions are discussed in #7741 >> <https://github.com/w3c/csswg-drafts/issues/7741> and #7063 >> <https://github.com/w3c/csswg-drafts/issues/7063>. >> >> I'll ping Emilio again to comment on the issue. Assuming that happens, I >> really see no blockers at all, and Chris Lilley seems to agree with us on >> that. >> >> Dominik >> >> >>> >>> On Thursday, November 9, 2023 at 4:02:34 PM UTC+1 moo...@google.com >>> wrote: >>> >>>> Submitted: >>>> >>>> - TAG review: https://github.com/w3ctag/design-reviews/issues/915 >>>> - Requested signals from the other vendors: >>>> - Gecko: https://github.com/mozilla/standards-positions/issues/925 >>>> - Webkit: >>>> https://github.com/WebKit/standards-positions/issues/276 >>>> >>>> Thank you, Daniel! >>>> >>>> On Wed, Nov 8, 2023 at 4:52 PM Daniel Bratell <bratel...@gmail.com> >>>> wrote: >>>> >>>>> Hi, could you please request signals from the other vendors? >>>>> https://bit.ly/blink-signals will tell you how they work. >>>>> >>>>> Also, you may want to file a TAG review, or give them a FYI or let us >>>>> know why that is not necessary. >>>>> >>>>> /Daniel >>>>> On 2023-11-08 13:56, 'Munira Tursunova' via blink-dev wrote: >>>>> >>>>> Contact emails moon...@google.com, dr...@google.com >>>>> >>>>> Explainer >>>>> https://docs.google.com/document/d/1XMTrKH003KBOes6hxzI-3E7LTwp5YwFC-rnzoFpFrfw/edit?usp=sharing >>>>> >>>>> Specification https://drafts.csswg.org/css-fonts-4/#font-palette-prop >>>>> >>>>> Summary >>>>> >>>>> The CSS font-palette property allows selection of a specific palette >>>>> used to render a font. The CSS Fonts 4 spec defines the animation behavior >>>>> of this property as discrete, which is insufficient to achieve a smooth >>>>> transition between two selected palettes. Instead, animating the >>>>> font-palette property should happen by interpolating each of the colour >>>>> record values from the defined palette, i.e. if the start or the end of >>>>> the >>>>> animation has a different colour value for some record in the palette, >>>>> such >>>>> colour value should be interpolated. >>>>> >>>>> >>>>> Blink component Blink>Fonts >>>>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EFonts> >>>>> >>>>> Search tags font-palette >>>>> <https://chromestatus.com/features#tags:font-palette>, animation >>>>> <https://chromestatus.com/features#tags:animation>, transition >>>>> <https://chromestatus.com/features#tags:transition>, >>>>> font-palette-values >>>>> <https://chromestatus.com/features#tags:font-palette-values>, color >>>>> fonts <https://chromestatus.com/features#tags:color%20fonts> >>>>> >>>>> TAG review None >>>>> >>>>> TAG review status Not applicable >>>>> >>>>> Risks >>>>> >>>>> >>>>> Interoperability and Compatibility >>>>> >>>>> Low, new feature, was resolved by W3C working group >>>>> https://github.com/w3c/csswg-drafts/issues/8922#issuecomment-1720930646, >>>>> but not yet implemented in other browsers. >>>>> >>>>> *Gecko*: No signal Not implemented. >>>>> >>>>> *WebKit*: No signal Not implemented. >>>>> >>>>> *Web developers*: Positive ( >>>>> https://css-tricks.com/colrv1-and-css-font-palette-web-typography/#:~:text=Another%20limitation%3A%20animations%20and%20transitions%20from%20one%20font%2Dpalette%20to%20another%20don%E2%80%99t%20interpolate%20%E2%80%94%20meaning%20you%20can%20switch%20instantly%20from%20one%20palette%20to%20another%2C%20but%20can%E2%80%99t%20gradually%20animate%20between%20them.%20My%20dream%20of%20a%20luridly%20animated%20emoji%20font%20is%20sadly%20unrealized) >>>>> Ollie Williams expressed his interest in the feature in his article on CSS >>>>> Tricks. Scott Kellum (of typetura.com) has also been suggesting it as >>>>> a useful feature for the web (origin: a Twitter thread and email >>>>> conversation, Scott in the meantime deleted their Twitter account). >>>>> >>>>> *Other signals*: >>>>> >>>>> WebView application risks >>>>> >>>>> Does this intent deprecate or change behavior of existing APIs, such >>>>> that it has potentially high risk for Android WebView-based applications? >>>>> >>>>> None >>>>> >>>>> >>>>> Debuggability >>>>> >>>>> Same as any other CSS property, font-palette property is inspectable >>>>> in DevTools. >>>>> >>>>> >>>>> Will this feature be supported on all six Blink platforms (Windows, >>>>> Mac, Linux, Chrome OS, Android, and Android WebView)? Yes >>>>> >>>>> Is this feature fully tested by web-platform-tests >>>>> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >>>>> ? Yes >>>>> >>>>> https://wpt.fyi/results/css/css-fonts/palette-mix-computed.html >>>>> https://wpt.fyi/results/css/css-fonts/animations/font-palette-interpolation.html >>>>> >>>>> >>>>> Flag name on chrome://flags FontPaletteAnimation >>>>> >>>>> Finch feature name None >>>>> >>>>> Non-finch justification None >>>>> >>>>> Requires code in //chrome? False >>>>> >>>>> Tracking bug >>>>> https://bugs.chromium.org/p/chromium/issues/detail?id=1400620 >>>>> >>>>> Sample links >>>>> https://drafts.csswg.org/css-fonts-4/images/nabla-animated.webp >>>>> >>>>> Estimated milestones >>>>> Shipping on desktop 121 >>>>> DevTrial on desktop 119 >>>>> Shipping on Android 121 >>>>> DevTrial on Android 119 >>>>> Shipping on WebView 121 >>>>> >>>>> Anticipated spec changes >>>>> >>>>> Open questions about a feature may be a source of future web compat or >>>>> interop issues. Please list open issues (e.g. links to known github issues >>>>> in the project for the feature specification) whose resolution may >>>>> introduce web compat/interop risk (e.g., changing to naming or structure >>>>> of >>>>> the API in a non-backward-compatible way). >>>>> None >>>>> >>>>> Link to entry on the Chrome Platform Status >>>>> https://chromestatus.com/feature/5177171439517696 >>>>> >>>>> Links to previous Intent discussions Intent to prototype: >>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAAO7W_DFvgY9yqz_Tr%2B2sHMwsydbWMQ66yZWwF7ZoxDZ2yE1QA%40mail.gmail.com >>>>> >>>>> This intent message was generated by Chrome Platform Status >>>>> <https://chromestatus.com/>. >>>>> -- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "blink-dev" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to blink-dev+unsubscr...@chromium.org. >>>>> To view this discussion on the web visit >>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAAO7W_Bao93XoyHRT6NKG6p4pP87pQ0bvTedXOiGc_2hX3E7Jw%40mail.gmail.com >>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAAO7W_Bao93XoyHRT6NKG6p4pP87pQ0bvTedXOiGc_2hX3E7Jw%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>>> . >>>>> >>>>> -- >>> You received this message because you are subscribed to the Google >>> Groups "blink-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to blink-dev+unsubscr...@chromium.org. >>> To view this discussion on the web visit >>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/85a8ff9f-03e2-4434-bc29-f7d02130e8e3n%40chromium.org >>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/85a8ff9f-03e2-4434-bc29-f7d02130e8e3n%40chromium.org?utm_medium=email&utm_source=footer> >>> . >>> >> -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfU%3DKmysPKGBfykEE7Kv1g%3D9tO8bEq87Tfaw9knb9-uAZg%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfU%3DKmysPKGBfykEE7Kv1g%3D9tO8bEq87Tfaw9knb9-uAZg%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/ce826ae3-ed8a-44c9-a62f-64d7ad1bb36e%40chromium.org > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/ce826ae3-ed8a-44c9-a62f-64d7ad1bb36e%40chromium.org?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY9XDgZWMK4_k-syQ%2BAwgfDRO_JHfai0V%3DzRSTcpvjUhZA%40mail.gmail.com.
