LGTM2 /Daniel
On 2023-08-09 00:37, PhistucK wrote:
They chose "open issues in our Github repo for each point of feedback" as the result of the review and the mentioned issue was filed, with a resolution to compute the keywords to themselves, rather than to the physical values.☆*PhistucK* On Tue, Aug 8, 2023 at 9:06 PM Mike Taylor <miketa...@chromium.org> wrote: LGTM1 On 8/8/23 7:11 AM, obr...@igalia.com wrote:I got an email saying that new features will be announced in blog posts and enterprise release notes about 1 week before a milestone reaches beta. We are close to that point and still no LGTM, so I guess it's better to delay this and try to target 118 instead. El dia dimecres, 2 d’agost de 2023 a les 21:57:58 UTC+2, obr...@igalia.com va escriure: Contact emails obr...@igalia.com Explainer https://www.smashingmagazine.com/2018/03/understanding-logical-properties-values/ Specification https://drafts.csswg.org/css-logical/#directional-keywords https://drafts.csswg.org/css-ui/#resize <https://drafts.csswg.org/css-logical/#directional-keywords,https://drafts.csswg.org/css-ui/%23resize> Design docs https://developer.mozilla.org/docs/Web/CSS/CSS_logical_properties_and_values Summary Add these new values to existing CSS properties: - float: inline-start - float: inline-end - clear: inline-start - clear: inline-end - resize: block - resize: inline Blink component Blink>CSS <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3ECSS> Search tags css-logical <https://chromestatus.com/features#tags:css-logical> TAG review https://github.com/w3ctag/design-reviews/issues/286 The only issue relevant to logical values washttps://github.com/w3c/csswg-drafts/issues/2821, which was addressed in the spec, and Blink obeys the resolution.It's not clear what the resolution is/was - I just see a few linked issues and it being closed without any comment (maybe the TAG had a different operating model back in 2018...).-- You received this message because you are subscribed to the GoogleTAG review status Issues addressed Risks Interoperability and Compatibility Gecko and WebKit already shipped. Gecko doesn't follow the spec. /Gecko/: Shipped/Shipping (https://bugzilla.mozilla.org/show_bug.cgi?id=1253919, https://bugzilla.mozilla.org/show_bug.cgi?id=1464786 <https://bugzilla.mozilla.org/show_bug.cgi?id=1253919,https://bugzilla.mozilla.org/show_bug.cgi?id=1464786>) The implementation is wrong, seehttps://bugzilla.mozilla.org/show_bug.cgi?id=1661548 /WebKit/: Shipped/Shipping (https://bugs.webkit.org/show_bug.cgi?id=218087, https://bugs.webkit.org/show_bug.cgi?id=218088 <https://bugs.webkit.org/show_bug.cgi?id=218087,https://bugs.webkit.org/show_bug.cgi?id=218088>) /Web developers/: Positive (https://bugs.chromium.org/p/chromium/issues/detail?id=850004#c8) /Other signals/: WebView application risks Does this intent deprecate or change behavior of existing APIs, such that it has potentially high risk for Android WebView-based applications? None Debuggability The DevTools Styles panel’s autocomplete functionality is already aware of these new values. Will this feature be supported on all six Blink platforms (Windows, Mac, Linux, Chrome OS, Android, and Android WebView)? Yes Is this feature fully tested byweb-platform-tests <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md>? Yes Flag name on chrome://flags None Finch feature name CSSLogical (This is the feature name in runtime_enabled_features.json5, which seemingly I'm supposed to provide here, but it's not actually using Finch) Requires code in //chrome? False Tracking bug https://crbug.com/850004 Estimated milestones Shipping on desktop 117 DevTrial on desktop 70 Shipping on Android 117 DevTrial on Android 70 Shipping on WebView 117 Anticipated spec changes Open questions about a feature may be a source of future web compat or interop issues. Please list open issues (e.g. links to known github issues in the project for the feature specification) whose resolution may introduce web compat/interop risk (e.g., changing to naming or structure of the API in a non-backward-compatible way). None Link to entry on the Chrome Platform Status https://chromestatus.com/feature/6237096230518784 Links to previous Intent discussions Intent to prototype:https://groups.google.com/a/chromium.org/d/msg/blink-dev/48OwfwZrbvI/A1XZFGkzAwAJ This intent message was generated byChrome Platform Status <https://chromestatus.com/>.-- You received this message because you are subscribed to theGoogle Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/dde4620a-3303-48d6-bee1-c31450e42899n%40chromium.org <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/dde4620a-3303-48d6-bee1-c31450e42899n%40chromium.org?utm_medium=email&utm_source=footer>.Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/19bb567c-6abf-46c5-9cd8-ff0962fce474%40chromium.org <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/19bb567c-6abf-46c5-9cd8-ff0962fce474%40chromium.org?utm_medium=email&utm_source=footer>. --You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CABc02_JMiG%2BPpmU16Wi4T-zHq2DP6EAMJJG4u4YgiHkhaMmEew%40mail.gmail.com <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CABc02_JMiG%2BPpmU16Wi4T-zHq2DP6EAMJJG4u4YgiHkhaMmEew%40mail.gmail.com?utm_medium=email&utm_source=footer>.
-- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/a7744d39-ca82-c4d0-7925-4a38512a7816%40gmail.com.
