FYI: due to compat issues I encountered while launching this feature, we decided to create a CSS property to opt-in to the new behavior. It was resolved by the CSSWG here: https://github.com/w3c/csswg-drafts/issues/8857
On Wed, Apr 5, 2023 at 8:49 AM Rick Byers <[email protected]> wrote: > LGTM3 > > On Wed, Apr 5, 2023 at 11:40 AM Daniel Bratell <[email protected]> > wrote: > >> LGTM2 >> >> /Daniel >> On 2023-04-05 17:39, Alex Russell wrote: >> >> Thanks everyone for adding an Explainer, etc. I'm a little worried that >> this is another feature that skimped on developer engagement (Explainers) >> and review (TAG) until I2S. They both came very late, and if the feature >> itself wasn't seemingly landed as a closed spec PR, I'd be blocking this >> for another few weeks/months until TAG had a chance to properly discuss. >> >> Let's not do this again? >> >> Regardless, LGTM1. >> >> On Wednesday, March 22, 2023 at 8:56:33 AM UTC-7 Rick Byers wrote: >> >>> We discussed this in the API owners meeting today. Since position >>> requests were just filed, we'd like to give this another week to see if >>> anyone has any feedback. But otherwise we're excited to see this ship. >>> >>> Rick >>> >>> On Wed, Mar 15, 2023 at 6:10 PM Joey Arhar <[email protected]> wrote: >>> >>>> TAG review: https://github.com/w3ctag/design-reviews/issues/825 >>>> WebKit standards position: >>>> https://github.com/WebKit/standards-positions/issues/148 >>>> Mozilla standards position: >>>> https://github.com/mozilla/standards-positions/issues/763 >>>> >>>> On Wed, Mar 15, 2023 at 1:30 PM Joey Arhar <[email protected]> wrote: >>>> >>>>> Contact emails [email protected], [email protected] >>>>> >>>>> Explainer >>>>> https://github.com/w3c/csswg-drafts/issues/4441#issuecomment-1329749962 >>>>> >>>>> Specification https://github.com/w3c/csswg-drafts/pull/8520 >>>>> >>>>> Summary >>>>> >>>>> Allows transitions of discrete properties to be started on properties >>>>> explicitly listed in the transition-property list. These transitions run >>>>> using the same logic as an animation on those properties performing a flip >>>>> at 50% by default but can be customized through the use of the >>>>> transitionstart event and web-animations-1 APIs for modifying transition >>>>> animations. >>>>> >>>>> >>>>> Blink component Blink>Animation >>>>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EAnimation> >>>>> >>>>> TAG review None >>>>> >>>>> TAG review status Not applicable >>>>> >>>>> Risks >>>>> >>>>> >>>>> Interoperability and Compatibility >>>>> >>>>> This is unlikely to have a big compatibility risk since the >>>>> transition-property: all keyword does not include discrete properties. >>>>> This >>>>> will only affect sites which have explicitly listed discrete properties in >>>>> transition-property. However given this used to be unsupported, it is >>>>> unlikely to have been specified on most sites. This will also now be doing >>>>> what the developer requested. >>>>> >>>>> >>>>> *Gecko*: No signal >>>>> >>>>> *WebKit*: No signal >>>>> >>>>> *Web developers*: No signals >>>>> >>>>> *Other signals*: >>>>> >>>>> Ergonomics >>>>> >>>>> This will be used in tandem with the popover attribute and >>>>> CSSDisplayAnimation. This feature will not make it hard for chrome to >>>>> maintain good performance. >>>>> >>>>> >>>>> Activation >>>>> >>>>> This will not be hard for developers to use immediately. >>>>> >>>>> >>>>> Security >>>>> >>>>> This does not do anything that the developer could not have set with >>>>> their own stylesheets or script and shouldn't have any risks. >>>>> >>>>> >>>>> WebView application risks >>>>> >>>>> Does this intent deprecate or change behavior of existing APIs, such >>>>> that it has potentially high risk for Android WebView-based applications? >>>>> >>>>> This is not high risk for WebView, but is controlled by a >>>>> base::Feature anyway. >>>>> >>>>> >>>>> Debuggability >>>>> >>>>> This feature would be consistent with existing CSS transitions, >>>>> showing up the dev tools animation timeline and generating transition >>>>> events. No new interfaces should be needed. >>>>> >>>>> >>>>> Will this feature be supported on all six Blink platforms (Windows, >>>>> Mac, Linux, Chrome OS, Android, and Android WebView)? Yes >>>>> >>>>> Is this feature fully tested by web-platform-tests >>>>> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >>>>> ? Yes >>>>> >>>>> Flag name CSSTransitionDiscrete >>>>> >>>>> Requires code in //chrome? False >>>>> >>>>> Tracking bug >>>>> https://bugs.chromium.org/p/chromium/issues/detail?id=1399631 >>>>> >>>>> Measurement This feature does not have any UseCounters. >>>>> >>>>> Availability expectation I'm not sure when this will be implemented >>>>> in safari and firefox. I don't think that they have started implementing >>>>> this yet, but we only very recently got this resolved in CSSWG. >>>>> >>>>> Adoption expectation This will be the best practice for animating the >>>>> entry and exit if dialogs and popovers immediately. >>>>> >>>>> Adoption plan I don't have an adoption plan. >>>>> >>>>> Non-OSS dependencies >>>>> >>>>> Does the feature depend on any code or APIs outside the Chromium open >>>>> source repository and its open-source dependencies to function? >>>>> This feature does not depend on anything outside of chromium. >>>>> >>>>> Sample links https://output.jsbin.com/buquher/quiet >>>>> >>>>> Estimated milestones >>>>> >>>>> M114 >>>>> >>>>> Anticipated spec changes >>>>> >>>>> Open questions about a feature may be a source of future web compat or >>>>> interop issues. Please list open issues (e.g. links to known github issues >>>>> in the project for the feature specification) whose resolution may >>>>> introduce web compat/interop risk (e.g., changing to naming or structure >>>>> of >>>>> the API in a non-backward-compatible way). >>>>> This change has been specced and I don't think any more changes to the >>>>> spec will happen. >>>>> >>>>> Link to entry on the Chrome Platform Status >>>>> https://chromestatus.com/feature/5071230636392448 >>>>> >>>>> Links to previous Intent discussions Intent to prototype: >>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAJh39TMR_5Tz3OHKo16aB3h6vqLKZBaHt3rh%2Bse454y-hT%2B1-A%40mail.gmail.com >>>>> >>>>> >>>>> This intent message was generated by Chrome Platform Status >>>>> <https://chromestatus.com/>. >>>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "blink-dev" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected]. >>>> To view this discussion on the web visit >>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAK6btw%2BzRSkwmCxUP0atTCXnVr2J8_dDYaaqn5UCfbdTOE5S%3Dg%40mail.gmail.com >>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAK6btw%2BzRSkwmCxUP0atTCXnVr2J8_dDYaaqn5UCfbdTOE5S%3Dg%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>> . >>>> >>> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/c596fc81-9a93-4364-bd31-469624023a20n%40chromium.org >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/c596fc81-9a93-4364-bd31-469624023a20n%40chromium.org?utm_medium=email&utm_source=footer> >> . >> >> -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAK6btwJS8KHqb980jkUVHzY3%2B5wRTKGi7FudCA6D-dDdQ3yPbA%40mail.gmail.com.
