Thanks, LGTM3

On Mon, May 15, 2023 at 10:45 AM Yoav Weiss <[email protected]> wrote:

>
>
> On Mon, May 15, 2023 at 4:43 PM Mike Taylor <[email protected]>
> wrote:
>
>> I see that both the Resource Timing
>> <https://github.com/w3c/resource-timing/pull/341> and Fetch
>> <https://github.com/whatwg/fetch/pull/1481> PRs have landed - does that
>> mean this I2S is unblocked now (and just needs an LGTM3)?
>>
>
> I believe so.
>
>
>> On 5/3/23 3:55 AM, Yoav Weiss wrote:
>>
>> Update: +Anne van Kesteren <[email protected]> has been working on a new 
>> MimeSniff
>> spec concept <https://github.com/whatwg/mimesniff/pull/171> that will
>> enable this feature to only expose supported mime types, rather than any
>> arbitrary one. (to prevent a threat model
>> <https://w3c.github.io/web-performance/meetings/2022/2022-09-TPAC/#h.6kkgtdwd0pos>
>>  Apple
>> folks are concerned with, without harming the use-cases the feature is
>> tackling)
>>
>> We'd need to modify the spec PR and implementation to rely on that
>> concept.
>>
>> On Thu, Apr 20, 2023 at 8:35 AM Yoav Weiss <[email protected]>
>> wrote:
>>
>>>
>>>
>>> On Wed, Apr 19, 2023 at 6:03 PM Rick Byers <[email protected]> wrote:
>>>
>>>> Hi Abin (or Yoav?),
>>>> What's blocking this spec PR from landing?
>>>>
>>>
>>> Nothing is blocking
>>> <https://github.com/whatwg/fetch/pull/1481#issuecomment-1503115916> AFAICT.
>>> Just a matter of someone with permissions clicking the button.
>>>
>>>
>>>> As discussed here
>>>> <https://groups.google.com/a/chromium.org/g/blink-dev/c/f28WWMD8HVE/m/xCrQN-8hAgAJ>,
>>>> our standard process is to do what we can to get spec changes fully landed
>>>> if possible.
>>>>
>>>
>>> I think this can wait a few days until the button-clicking happens.
>>>
>>>
>>>>
>>>> Thanks,
>>>>    Rick
>>>>
>>>> On Wed, Apr 12, 2023 at 11:25 AM Daniel Bratell <[email protected]>
>>>> wrote:
>>>>
>>>>> /LGTM2
>>>>>
>>>>> /Daniel
>>>>> On 2023-04-12 00:54, Mike Taylor wrote:
>>>>>
>>>>> LGTM1
>>>>> On 4/11/23 5:27 AM, Yoav Weiss wrote:
>>>>>
>>>>> Thanks for working on this Abin and for pushing this over the line!!
>>>>> (I'm recusing myself as an API owner, as I was involved in that work)
>>>>>
>>>>> On Sat, Apr 8, 2023 at 1:11 AM Abin Paul <[email protected]> wrote:
>>>>>
>>>>>> Contact emails
>>>>>>
>>>>>> [email protected]
>>>>>>
>>>>>> Explainer
>>>>>>
>>>>>>
>>>>>> https://github.com/abinpaul1/resource-timing/blob/explainer-content-type/Explainers/Content-Type.md
>>>>>>
>>>>>> Specification
>>>>>>
>>>>>> Resource Timing PR : https://github.com/w3c/resource-timing/pull/341
>>>>>>
>>>>>> Fetch PR : https://github.com/whatwg/fetch/pull/1481
>>>>>>
>>>>>>
>>>>>> Summary
>>>>>>
>>>>>> Adds a field to PerformanceResourceTiming that holds a string
>>>>>> corresponding to the Content-type header of the fetched resource when the
>>>>>> resource was fetched.
>>>>>>
>>>>>>
>>>>>> Blink component
>>>>>>
>>>>>> Blink>PerformanceAPIs>ResourceTiming
>>>>>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EPerformanceAPIs%3EResourceTiming>
>>>>>>
>>>>>> TAG review
>>>>>>
>>>>>> https://github.com/w3ctag/design-reviews/issues/785
>>>>>>
>>>>>> TAG review status
>>>>>>
>>>>>> Issues addressed
>>>>>>
>>>>>> Risks
>>>>>>
>>>>>> Interoperability and Compatibility
>>>>>>
>>>>>> Gecko: Positive (
>>>>>> https://github.com/mozilla/standards-positions/issues/705)
>>>>>>
>>>>>> WebKit: No signal (
>>>>>> https://github.com/WebKit/standards-positions/issues/88)
>>>>>>
>>>>>> Web developers:
>>>>>>
>>>>>> Developer interest for the feature :
>>>>>> https://github.com/w3c/resource-timing/issues/203
>>>>>>
>>>>>> Other signals:
>>>>>>
>>>>>> Ergonomics
>>>>>>
>>>>>> No
>>>>>>
>>>>>>
>>>>>> Activation
>>>>>>
>>>>>> No risks
>>>>>>
>>>>>>
>>>>>> Security
>>>>>>
>>>>>> No risks
>>>>>>
>>>>>>
>>>>>> WebView application risks
>>>>>>
>>>>>> Does this intent deprecate or change behaviour of existing APIs, such
>>>>>> that it has potentially high risk for Android WebView-based applications?
>>>>>> No
>>>>>>
>>>>>>
>>>>>> Debuggability
>>>>>>
>>>>>> The new attribute shows up in Devtools. No implementation changes are
>>>>>> required.
>>>>>>
>>>>>> Will this feature be supported on all six Blink platforms (Windows,
>>>>>> Mac, Linux, Chrome OS, Android, and Android WebView)?
>>>>>>
>>>>>> Yes
>>>>>>
>>>>>> Is this feature fully tested by web-platform-tests
>>>>>> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md>
>>>>>> ?
>>>>>>
>>>>>> Yes
>>>>>>
>>>>>>
>>>>>> https://wpt.fyi/results/resource-timing/content-type.html?label=master&label=experimental&aligned
>>>>>>
>>>>>> https://wpt.fyi/results/resource-timing/content-type-parsing.html?label=master&label=experimental&aligned
>>>>>>
>>>>>> Flag name
>>>>>>
>>>>>> #enable-experimental-web-platform-features
>>>>>>
>>>>>> Requires code in //chrome?
>>>>>>
>>>>>> False
>>>>>>
>>>>>> Tracking bug
>>>>>>
>>>>>> https://bugs.chromium.org/p/chromium/issues/detail?id=1366706
>>>>>>
>>>>>>
>>>>>> Non-OSS dependencies
>>>>>>
>>>>>> Does the feature depend on any code or APIs outside the Chromium open
>>>>>> source repository and its open-source dependencies to function?
>>>>>>
>>>>>> No
>>>>>>
>>>>>> Estimated milestones
>>>>>>
>>>>>> Chrome for desktop 115
>>>>>>
>>>>>> Chrome for Android 115
>>>>>>
>>>>>> Android Webview 115
>>>>>>
>>>>>>
>>>>>> Anticipated spec changes
>>>>>>
>>>>>> No ongoing discussion that could lead to future changes
>>>>>>
>>>>>>
>>>>>> Link to entry on the Chrome Platform Status
>>>>>>
>>>>>> https://chromestatus.com/feature/5156068351541248
>>>>>>
>>>>>> Links to previous Intent discussions
>>>>>>
>>>>>> Intent to prototype:
>>>>>> https://groups.google.com/a/chromium.org/g/blink-dev/c/Dk2uL_gXpZc/m/OhY2ZomeAwAJ
>>>>>> --
>>>>>> You received this message because you are subscribed to the Google
>>>>>> Groups "blink-dev" group.
>>>>>> To unsubscribe from this group and stop receiving emails from it,
>>>>>> send an email to [email protected].
>>>>>> To view this discussion on the web visit
>>>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAM2ZH3c1k1fLSb-GmSPEs9MsZDY-O3TaGn9PuvT7DL2NATWFPQ%40mail.gmail.com
>>>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAM2ZH3c1k1fLSb-GmSPEs9MsZDY-O3TaGn9PuvT7DL2NATWFPQ%40mail.gmail.com?utm_medium=email&utm_source=footer>
>>>>>> .
>>>>>>
>>>>> --
>>>>> You received this message because you are subscribed to the Google
>>>>> Groups "blink-dev" group.
>>>>> To unsubscribe from this group and stop receiving emails from it, send
>>>>> an email to [email protected].
>>>>> To view this discussion on the web visit
>>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfUjfO88eOh3k1xdp1dSJKDdx%3DA2-6_qQD1KoowbfkGZmQ%40mail.gmail.com
>>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfUjfO88eOh3k1xdp1dSJKDdx%3DA2-6_qQD1KoowbfkGZmQ%40mail.gmail.com?utm_medium=email&utm_source=footer>
>>>>> .
>>>>>
>>>>> --
>>>>> You received this message because you are subscribed to the Google
>>>>> Groups "blink-dev" group.
>>>>> To unsubscribe from this group and stop receiving emails from it, send
>>>>> an email to [email protected].
>>>>> To view this discussion on the web visit
>>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/7dd0e397-123b-57f6-bab6-8df4087529ee%40chromium.org
>>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/7dd0e397-123b-57f6-bab6-8df4087529ee%40chromium.org?utm_medium=email&utm_source=footer>
>>>>> .
>>>>>
>>>>> --
>>>>> You received this message because you are subscribed to the Google
>>>>> Groups "blink-dev" group.
>>>>> To unsubscribe from this group and stop receiving emails from it, send
>>>>> an email to [email protected].
>>>>> To view this discussion on the web visit
>>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/9b8cf680-9647-1ca7-a6fe-d034e737e9da%40gmail.com
>>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/9b8cf680-9647-1ca7-a6fe-d034e737e9da%40gmail.com?utm_medium=email&utm_source=footer>
>>>>> .
>>>>>
>>>> --
>> You received this message because you are subscribed to the Google Groups
>> "blink-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to [email protected].
>> To view this discussion on the web visit
>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/6388a806-7b9e-c8c1-6b52-f84e7b473558%40chromium.org
>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/6388a806-7b9e-c8c1-6b52-f84e7b473558%40chromium.org?utm_medium=email&utm_source=footer>
>> .
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY_CSPXn8YzqynMH6BFQALZHMv-KA%2B48hi7j7ntZP6zV2Q%40mail.gmail.com.

Reply via email to