Got it, thanks Kevin! On Wed, Jan 11, 2023 at 2:14 PM Kevin McNee <mc...@chromium.org> wrote:
> Thank you. > > For the tests, I had the following comment in the chrome status entry, > which unfortunately I didn't notice wasn't included in the generated email: > Web Platform Tests Description > > https://wpt.fyi/results/speculation-rules/prefetch?label=master&label=experimental&aligned&view=subtest&q=referrer-policy-from-rules.https.html > > https://wpt.fyi/results/speculation-rules/prerender?label=master&label=experimental&aligned&view=subtest&q=referrer-policy-from-rules.html > Tests may appear as failing on wpt.fyi as prefetch is not > shipped/experimental on desktop (as of Dec 12 2022). > > So for Rick's question, the only thing needed for coverage is the enabling > of underlying features (namely prefetch) and any other speculation rule > features with which these tests interact (e.g. document rules). > On Wednesday, January 11, 2023 at 12:20:39 p.m. UTC-5 Yoav Weiss wrote: > >> LGTM3 >> >> On Wed, Jan 11, 2023 at 6:19 PM Rick Byers <rby...@chromium.org> wrote: >> >>> Seems like a valuable and low-risk small addition to pre-fetching. LGTM2 >>> >>> I see the tests are failing >>> <https://wpt.fyi/results/speculation-rules/prefetch?label=master&label=experimental&aligned&view=subtest&q=referrer-policy-from-rules.https.html> >>> on wpt.fyi >>> <https://wpt.fyi/results/speculation-rules/prerender?label=master&label=experimental&aligned&view=subtest&q=referrer-policy-from-rules.html> >>> due to prefetch not yet being enabled on desktop, right? Once prefetch >>> ships on desktop will they start passing there, or is there more test infra >>> work to do? Regardless it looks like they're passing in chromium >>> infrastructure (modulo one bug >>> <https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/TestExpectations;l=241>) >>> so I'm not too concerned. I'm just looking forward to having the full test >>> suite results on wpt.fyi. >>> >>> Thanks, >>> Rick >>> >>> On Wed, Jan 11, 2023 at 12:13 PM Mike Taylor <miketa...@chromium.org> >>> wrote: >>> >>>> This is important to have. LGTM1. >>>> >>>> On 1/10/23 3:26 PM, Kevin McNee wrote: >>>> >>>> Note: See this intent >>>> <https://groups.google.com/a/chromium.org/g/blink-dev/c/3Ga0Y2BEz7E/m/QRQyXY7UCQAJ> >>>> for context on reintroducing the sufficiently-strict referrer policy >>>> requirement. >>>> >>>> On Tuesday, January 10, 2023 at 3:20:43 p.m. UTC-5 Kevin McNee wrote: >>>> >>>>> Contact emails >>>>> >>>>> mc...@chromium.org >>>>> >>>>> Explainer >>>>> >>>>> >>>>> https://github.com/WICG/nav-speculation/blob/main/triggers.md#explicit-referrer-policy >>>>> >>>>> Specification >>>>> >>>>> https://wicg.github.io/nav-speculation/speculation-rules.html >>>>> >>>>> Summary >>>>> >>>>> This extends the speculation rules [1] syntax to allow developers to >>>>> specify the referrer policy to use with speculative requests triggered by >>>>> speculation rules. >>>>> >>>>> This also reintroduces the "sufficiently-strict referrer policy" >>>>> requirement [2]. >>>>> >>>>> [1] https://chromestatus.com/feature/5740655424831488 >>>>> >>>>> [2] >>>>> https://github.com/WICG/nav-speculation/blob/main/fetch.md#stripping-referrer-information >>>>> >>>>> >>>>> Blink component >>>>> >>>>> Internals>Preload >>>>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Internals%3EPreload> >>>>> >>>>> TAG review >>>>> >>>>> https://github.com/w3ctag/design-reviews/issues/721 >>>>> >>>>> TAG review status >>>>> >>>>> Pending >>>>> >>>>> Risks >>>>> >>>>> Interoperability and Compatibility >>>>> >>>>> Gecko: No signal ( >>>>> https://github.com/mozilla/standards-positions/issues/620) >>>>> >>>>> WebKit: No signal ( >>>>> https://github.com/WebKit/standards-positions/issues/54) >>>>> >>>>> Web developers: Positive We have a partner that requires this >>>>> capability to adopt cross-site prefetch, and another that requires this >>>>> for >>>>> same-origin prerendering. >>>>> >>>>> Other signals: >>>>> >>>>> WebView application risks >>>>> >>>>> Does this intent deprecate or change behavior of existing APIs, such >>>>> that it has potentially high risk for Android WebView-based applications? >>>>> >>>>> No. Enforcing the referrer policy requirement would not cause >>>>> user-visible breakage, since preloading is a performance-enhancement >>>>> feature that isn't guaranteed to trigger anyway. >>>>> >>>>> >>>>> Debuggability >>>>> >>>>> In the DevTools Network tab, the speculative request can be selected >>>>> to see referrer information. >>>>> >>>>> >>>>> Will this feature be supported on all six Blink platforms (Windows, >>>>> Mac, Linux, Chrome OS, Android, and Android WebView)? >>>>> >>>>> Yes >>>>> >>>>> Is this feature fully tested by web-platform-tests >>>>> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >>>>> ? >>>>> >>>>> Yes >>>>> >>>>> Flag name >>>>> >>>>> SpeculationRulesReferrerPolicyKey (Runtime Enabled Feature) >>>>> >>>>> Requires code in //chrome? >>>>> >>>>> False >>>>> >>>>> Tracking bug >>>>> >>>>> https://bugs.chromium.org/p/chromium/issues/detail?id=1355146 >>>>> >>>>> Estimated milestones >>>>> >>>>> We would like to ship this in M111. >>>>> >>>>> >>>>> Anticipated spec changes >>>>> >>>>> Open questions about a feature may be a source of future web compat or >>>>> interop issues. Please list open issues (e.g. links to known github issues >>>>> in the project for the feature specification) whose resolution may >>>>> introduce web compat/interop risk (e.g., changing to naming or structure >>>>> of >>>>> the API in a non-backward-compatible way). >>>>> >>>>> None anticipated. >>>>> >>>>> Link to entry on the Chrome Platform Status >>>>> >>>>> https://chromestatus.com/feature/4694585584910336 >>>>> >>>>> Links to previous Intent discussions >>>>> >>>>> Intent to prototype: >>>>> https://groups.google.com/a/chromium.org/g/blink-dev/c/qzElfWpzWXg/m/yC8gOtcBAwAJ >>>>> >>>>> >>>>> This intent message was generated by Chrome Platform Status >>>>> <https://chromestatus.com/>. >>>>> >>>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "blink-dev" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to blink-dev+unsubscr...@chromium.org. >>>> To view this discussion on the web visit >>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/488e3cc7-a05b-4b16-9e9f-1ef78b8eac7fn%40chromium.org >>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/488e3cc7-a05b-4b16-9e9f-1ef78b8eac7fn%40chromium.org?utm_medium=email&utm_source=footer> >>>> . >>>> >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "blink-dev" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to blink-dev+unsubscr...@chromium.org. >>>> To view this discussion on the web visit >>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/1abe629b-136b-ea17-89dd-236f32446c92%40chromium.org >>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/1abe629b-136b-ea17-89dd-236f32446c92%40chromium.org?utm_medium=email&utm_source=footer> >>>> . >>>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "blink-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to blink-dev+unsubscr...@chromium.org. >>> >> To view this discussion on the web visit >>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY9TKqcHrAg1Zi8Xz74k_pkbZzDoMsn-K3yqKUyB2Juc9Q%40mail.gmail.com >>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY9TKqcHrAg1Zi8Xz74k_pkbZzDoMsn-K3yqKUyB2Juc9Q%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> >> -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY_LStdCYfiOm%3DZ12vBzj6pmJKVYfn2xGJGH-QeW00-YjA%40mail.gmail.com.
