That's amazing! Thank you for reducing the amount of boilerplate and hoops Chromium devs have to jump through to enable experimentation!!
On Sat, Sep 17, 2022 at 6:52 PM Ian Clelland <iclell...@chromium.org> wrote: > I ran into one of these in the wild, in a code review yesterday. It's a > huge win for reducing boilerplate code for new features (especially those > entering an Origin Trial, which usually need extra browser flags over and > above whatever blink-side control they already implement) > > Thanks for doing this! > > On Wed, Sept 14, 2022, 4:19 p.m. TAMURA, Kent <tk...@chromium.org> wrote: > >> ** blink::WebRuntimeFeatures methods generation* >> >> You can generate methods of blink::WebRuntimeFeatures for a feature >> entry in runtime_enabled_features.json5 by adding `public: true,`. >> >> ** base::Feature generation* >> >> You can generate a base::Feature instance in blink::features namespace >> for a feature entry in runtime_enabled_features.json5 by adding >> `base_feature: >> "*feature-name*",`. >> >> You can't use it for a base::Feature not in blink::features. >> >> >> https://chromium.googlesource.com/chromium/src/+/main/third_party/blink/renderer/platform/RuntimeEnabledFeatures.md#generate-a-instance-from-a-blink-feature >> >> >> -- >> TAMURA Kent >> Software Engineer, Google >> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to blink-dev+unsubscr...@chromium.org. >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGH7WqEYU-6yXomZa%2BAp31SypGK0nH4%2BuqXYYfeAsq%2BxT-BWtQ%40mail.gmail.com >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGH7WqEYU-6yXomZa%2BAp31SypGK0nH4%2BuqXYYfeAsq%2BxT-BWtQ%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAK_TSXLjqkiu3QuQ9rR1V_6dGD43sffsuF%3DMxJnw%2Bb1hvE66_A%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAK_TSXLjqkiu3QuQ9rR1V_6dGD43sffsuF%3DMxJnw%2Bb1hvE66_A%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfUQymWu2ec_Z7_iVmuhfx6HR%2BM3C2yugWhy6ONqwoCe8g%40mail.gmail.com.
