I've filed an issue <https://github.com/web-platform-tests/wpt/issues/34665>, though I don't have access to add the "untestable" label
On Wed, Jun 29, 2022 at 12:54 PM Marijn Kruisselbrink <[email protected]> wrote: > FWIW, that is more or less how in chrome's tree we already automate some > of these "manual" WPT tests. Chrome has two private test APIs, one to set > whatever path file/directory pickers should return, and one to get a path > to a temporary (writable) directory. That doesn't really help for testing > most of the options passed to the various picker methods since their effect > generally isn't visible to the web (most options just change what the UI > looks like/behaves like), although for this particular one I suppose there > at least some web-visible/testable effects. > > https://github.com/web-platform-tests/wpt/issues/8114 is at least > tangentially related to the missing WP functionality > > On Wed, Jun 29, 2022 at 8:57 AM Philip Jägenstedt <[email protected]> > wrote: > >> Hi Austin, >> >> Would you mind filing a bug for this testing capability for WPT at >> >> https://github.com/web-platform-tests/wpt/issues?q=is%3Aopen+is%3Aissue+label%3Atype%3Auntestable >> ? >> >> It sounds like what you need here is a WebDriver end point that >> configures the browser to automatically resolve a >> showDirectoryPicker() call with a directory controlled by WebDriver. >> >> Tests would then do something like `await >> test_driver.set_directory_picker('/path/to/a/directory')` before the >> showDirectoryPicker() call. >> >> If you think that setup would make sense, I'd be happy to provide more >> pointers for how to get it done in the different layers. >> >> Best regards, >> Philip >> >> On Wed, Jun 29, 2022 at 5:22 PM 'Austin Sullivan' via blink-dev >> <[email protected]> wrote: >> > >> > This feature is covered by integration tests. showDirectoryPicker() >> only has manual WPT coverage, and since this launch only corresponds to >> changes in permission prompt behavior, WPTs didn't really make sense. >> > >> > On Wed, Jun 29, 2022 at 10:57 AM Chris Harrelson <[email protected]> >> wrote: >> >> >> >> >> >> >> >> On Wed, Jun 29, 2022 at 7:52 AM Mike West <[email protected]> wrote: >> >>> >> >>> LGTM2. Thank you for working with the permissions and UX teams to >> hammer out a reasonable approach here. >> >>> >> >>> -mike >> >>> >> >>> >> >>> On Mon, Jun 27, 2022 at 4:40 PM 'Austin Sullivan' via blink-dev < >> [email protected]> wrote: >> >>>> >> >>>> PR is landed >> >>>> >> >>>> On Fri, Jun 24, 2022 at 3:09 PM Austin Sullivan <[email protected]> >> wrote: >> >>>>> >> >>>>> I was waiting for approval on this I2S before landing, but clearly >> I had my order of operations inverted :) >> >>>>> >> >>>>> Also I could've sworn I was already in the WICG, but for some >> reason the IPR bot doesn't think I am. I've submitted another request... >> >>>>> >> >>>>> On Fri, Jun 24, 2022 at 11:49 AM Yoav Weiss <[email protected]> >> wrote: >> >>>>>> >> >>>>>> >> >>>>>> >> >>>>>> On Mon, Jun 13, 2022 at 1:58 PM 'Austin Sullivan' via blink-dev < >> [email protected]> wrote: >> >>>>>>> >> >>>>>>> Contact emails >> >>>>>>> >> >>>>>>> [email protected] >> >>>>>>> >> >>>>>>> Explainer >> >>>>>>> >> >>>>>>> None >> >>>>>>> >> >>>>>>> Specification >> >>>>>>> >> >>>>>>> https://github.com/WICG/file-system-access/pull/300 >> >>>>>> >> >>>>>> >> >>>>>> Anything preventing us from landing the PR? >> >>>>>> >> >>>>>>> >> >>>>>>> >> >>>>>>> >> >>>>>>> Summary >> >>>>>>> >> >>>>>>> Allow returning a directory with both read and write permissions >> in a single prompt for the File System Access API. Currently >> showDirectoryPicker() always returns a read-only directory (after showing a >> read access prompt), requiring a second permission prompt to get write >> access. This double-prompt is a poor user experience and contributes to >> confusion and permission fatigue among users. >> >>>>>>> >> >>>>>>> >> >>>>>>> Adds an optional "mode" option to DirectoryPickerOptions which >> can be specified as "read" or "readwrite". >> >>>>>>> >> >>>>>>> >> >>>>>>> >> >>>>>>> Blink component >> >>>>>>> >> >>>>>>> Blink>Storage>FileSystem >> >>>>>>> >> >>>>>>> TAG review >> >>>>>>> >> >>>>>>> We did not seek a TAG review given the small scope of this >> feature. This launch does not add any new capabilities, but merely provides >> the browser with enough information to combine two permission prompts into >> one. >> >>>>>>> >> >>>>>>> TAG review status >> >>>>>>> >> >>>>>>> N/A >> >>>>>>> >> >>>>>>> Risks >> >>>>>>> >> >>>>>>> >> >>>>>>> >> >>>>>>> Interoperability and Compatibility >> >>>>>>> >> >>>>>>> >> >>>>>>> >> >>>>>>> Gecko: No signal >> >>>>>>> >> >>>>>>> WebKit: No signal >> >>>>>>> >> >>>>>>> Web developers: Strongly positive ( >> https://github.com/WICG/file-system-access/issues/89) >> >>>>>>> >> >>>>>>> Other signals: >> >>>>>>> >> >>>>>>> WebView application risks >> >>>>>>> >> >>>>>>> Does this intent deprecate or change behavior of existing APIs, >> such that it has potentially high risk for Android WebView-based >> applications? >> >>>>>>> >> >>>>>>> No >> >>>>>>> >> >>>>>>> >> >>>>>>> >> >>>>>>> Debuggability >> >>>>>>> >> >>>>>>> N/A >> >>>>>>> >> >>>>>>> >> >>>>>>> >> >>>>>>> Will this feature be supported on all six Blink platforms >> (Windows, Mac, Linux, Chrome OS, Android, and Android WebView)? >> >>>>>>> >> >>>>>>> No - The File System Access API is not supported on Android >> >>>>>>> >> >>>>>>> Is this feature fully tested by web-platform-tests? >> >>>>>>> >> >>>>>>> No >> >> >> >> >> >> Can you clarify? Is it tested via wpt-internal, because of the status >> of the spec in WICG? Or is it not possible to test this feature via that >> kind of mechanism? If so, is it instead tested via integration tests? >> >> >> >>>>>>> >> >>>>>>> >> >>>>>>> >> >>>>>>> Flag name >> >>>>>>> >> >>>>>>> >> >>>>>>> >> >>>>>>> Requires code in //chrome? >> >>>>>>> >> >>>>>>> False >> >>>>>>> >> >>>>>>> Tracking bug >> >>>>>>> >> >>>>>>> https://crbug.com/1115632 >> >>>>>>> >> >>>>>>> Launch bug >> >>>>>>> >> >>>>>>> https://crbug.com/1213159 >> >>>>>>> >> >>>>>>> Estimated milestones >> >>>>>>> >> >>>>>>> 105 >> >>>>>>> >> >>>>>>> >> >>>>>>> >> >>>>>>> Anticipated spec changes >> >>>>>>> >> >>>>>>> Open questions about a feature may be a source of future web >> compat or interop issues. Please list open issues (e.g. links to known >> github issues in the project for the feature specification) whose >> resolution may introduce web compat/interop risk (e.g., changing to naming >> or structure of the API in a non-backward-compatible way). >> >>>>>>> >> >>>>>>> >> >>>>>>> >> >>>>>>> Link to entry on the Chrome Platform Status >> >>>>>>> >> >>>>>>> https://chromestatus.com/feature/6383970247770112 >> >>>>>>> >> >>>>>>> This intent message was generated by Chrome Platform Status. >> >>>>>>> >> >>>>>>> -- >> >>>>>>> You received this message because you are subscribed to the >> Google Groups "blink-dev" group. >> >>>>>>> To unsubscribe from this group and stop receiving emails from it, >> send an email to [email protected]. >> >>>>>>> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CADs-7rHzNmDAE89ZmOEBR5CNCGprOVUBasCjijADr1LxvAd_Qg%40mail.gmail.com >> . >> >>>> >> >>>> -- >> >>>> You received this message because you are subscribed to the Google >> Groups "blink-dev" group. >> >>>> To unsubscribe from this group and stop receiving emails from it, >> send an email to [email protected]. >> >>>> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CADs-7rEz2YSh35tGs_hq1ENBZsp-1Q3kVfEv19Chwbh8gjXTmw%40mail.gmail.com >> . >> >>> >> >>> -- >> >>> You received this message because you are subscribed to the Google >> Groups "blink-dev" group. >> >>> To unsubscribe from this group and stop receiving emails from it, >> send an email to [email protected]. >> >>> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAKXHy%3DeKR5jn7f%2BM5KB5%3DgvJR1bvsgZHRT3VRtTR7idC1AqU6w%40mail.gmail.com >> . >> > >> > -- >> > You received this message because you are subscribed to the Google >> Groups "blink-dev" group. >> > To unsubscribe from this group and stop receiving emails from it, send >> an email to [email protected]. >> > To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CADs-7rEztSpx1n8CfmKsAuRS0jx7NoSetSkzX2HZjxPTgh4LTg%40mail.gmail.com >> . >> >> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAARdPYd7XRXxH1JS1cPyo9s04fLeV-qidLY%3Dfas5icZLO30LDQ%40mail.gmail.com >> . >> > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CADs-7rE_ProXW0zvDt_W%2Brn76yOKRhVCnXBGdTPSUwRjRhOKUQ%40mail.gmail.com.
