*LGTM1* Thanks for doing the work of verifying this is not a breaking change!
On Wed, Dec 15, 2021 at 3:17 PM Yoav Weiss <[email protected]> wrote: > The public equivalent is > https://docs.google.com/spreadsheets/d/1WZTRBujaaFrtUaRnBOoVYzJkZuColXFN-GgToF6nR5Q/edit#gid=73457229 > > On Wed, Dec 15, 2021 at 2:46 PM Mike Taylor <[email protected]> > wrote: > >> Hi Sonia, >> >> Could you please make this spreadsheet public? >> >> thanks, >> Mike >> >> On 12/15/21 7:38 AM, Sonia Singla wrote: >> >> Link to spreadsheet[0] >> >> >> [0] >> https://docs.google.com/spreadsheets/d/1lChXA87u2r7yuBdfJu283UDsGhRGqT9ol2rVwVOQw0o/edit?resourcekey=0-yCKFjRfFk0RYeNm-d6DvFw#gid=1758573992 >> >> On Wednesday, December 15, 2021 at 2:37:19 PM UTC+2 Sonia Singla wrote: >> >>> Hi Everyone, >>> >>> So I tested some pages on mac and did not find any visual changes or >>> anything is breaking for the links I tested. I updated the sheet[0]. Once >>> we get the approvals to remove the property, I will be working on patches >>> >>> Sonia >>> CE Intern >>> Igalia >>> >>> >>> On Thursday, December 9, 2021 at 2:44:01 PM UTC+2 [email protected] >>> wrote: >>> >>>> Sorry for the delay to come back to you. I had started to check a few >>>> pages provided by Yoav manually and it seems similar pattern shows up: the >>>> counter is hit when the page specifies "font-family: -webkit-standard;" or >>>> (more rarely) "font-family: -webkit-standard, serif;" on some elements (*). >>>> This is similar to what Mike found on github and the same remarks apply, in >>>> particular: >>>> >>>> - that may theorically change the rendering, but more investigation is >>>> needed to be sure. >>>> - -webkit-standard would internally be used as a fallback anyway so >>>> there is no risk of missing glyphs if we ignore user-specified one. >>>> >>>> I discussed with Sonia Singla (coding experience student at Igalia) and >>>> she was interested in double-checking a few pages visually on macOS (since >>>> that's where the main concern is) to see if anything is broken, as well as >>>> finishing the work of landing this patch. We will comment further when this >>>> is done. >>>> >>>> (*) For completeness, see the attached output of the following bash >>>> command: >>>> >>>> for url in `cat $TEXT_FILE_WITH_THE_LIST_OF_URLS`; do >>>> echo $url >>>> $CONTENT_SHELL --run-web-tests $url 2>&1 | grep >>>> FamilyNameFromSettings | sed 's/.*FontSelector::FamilyNameFromSettings / >>>> /' >>>> echo >>>> done >>>> >>>> with the following patch logging the font-family when the counter is >>>> hit: >>>> >>>> --- a/third_party/blink/renderer/platform/fonts/font_selector.cc >>>> +++ b/third_party/blink/renderer/platform/fonts/font_selector.cc >>>> @@ -49,6 +49,7 @@ AtomicString FontSelector::FamilyNameFromSettings( >>>> UseCounter::Count( >>>> use_counter, >>>> WebFeature::kFontSelectorCSSFontFamilyWebKitPrefixStandard); >>>> + LOG(INFO) << "FontSelector::FamilyNameFromSettings " << >>>> font_description.Family().ToString().Utf8().data(); >>>> } >>>> >>>> >>>> Le 08/12/2021 à 17:56, Mike West a écrit : >>>> >>>> Friendly-pinging Mike's ping of Rick's suggestion. Is that analysis >>>> something you can spend some time on before we ship this? >>>> >>>> -mike >>>> >>>> >>>> >> -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfUpmasvRYhGAuOVGuJdRgna8ebkWMOMxXS%3D5R3AUkrgCQ%40mail.gmail.com.
