LGTM3

/Daniel

On 2021-08-26 08:57, Yoav Weiss wrote:
LGTM2

On Wed, Aug 25, 2021 at 11:30 PM Chris Harrelson <chris...@chromium.org <mailto:chris...@chromium.org>> wrote:

    LGTM1

    On Wed, Aug 25, 2021 at 2:14 PM Xiaocheng Hu
    <xiaoche...@chromium.org <mailto:xiaoche...@chromium.org>> wrote:

        Here's an update that the TAG review has finished.

        Is there a chance that we can meet the feature freeze deadline
        tomorrow and ship it with M95?

        On Sat, Jul 31, 2021 at 1:00 PM Yoav Weiss
        <yoavwe...@chromium.org <mailto:yoavwe...@chromium.org>> wrote:

            Overall, aligning browsers on a single behavior for at
            rule inheritance seems like the right direction.
            I think it makes sense to let the TAG review run its
            course, as well as give positions from other vendors a bit
            more time.

            On Fri, Jul 23, 2021 at 2:32 AM Xiaocheng Hu
            <xiaoche...@chromium.org <mailto:xiaoche...@chromium.org>>
            wrote:


                        Contact emails

                xiaoche...@chromium.org <mailto:xiaoche...@chromium.org>


                        Explainer

                https://drafts.csswg.org/css-scoping/#example-f1503361
                <https://drafts.csswg.org/css-scoping/#example-f1503361>
                https://drafts.csswg.org/css-scoping/#example-ee72cb37
                <https://drafts.csswg.org/css-scoping/#example-ee72cb37>
                (While the examples use @font-face, @counter-style
                works in the same way)
                
<https://chromestatus.com/admin/features/launch/5716198446596096/(While%20the%20examples%20use%20@font-face,%20@counter-style%20works%20in%20the%20same%20way)>


                        Specification

                https://drafts.csswg.org/css-scoping/#shadow-names
                <https://drafts.csswg.org/css-scoping/#shadow-names>


                        Design docs


                https://bit.ly/2Gm1oMC <https://bit.ly/2Gm1oMC>


                        Summary

                Allows custom counter styles (@counter-style rules) to
                be defined with shadow trees, and properly referenced
                within shadow trees or across shadow boundaries.



                        Blink component

                Blink>CSS
                
<https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3ECSS>


                        Search tags

                css <https://chromestatus.com/features#tags:css>,
                counter
                <https://chromestatus.com/features#tags:counter>,
                counter-style
                <https://chromestatus.com/features#tags:counter-style>,
                shadow <https://chromestatus.com/features#tags:shadow>


                        TAG review

                https://github.com/w3ctag/design-reviews/issues/659
                <https://github.com/w3ctag/design-reviews/issues/659>


                        TAG review status

                Pending


                        Risks



                        Interoperability and Compatibility

                Low. Currently, browsers already have
                non-interoperable behaviors on how to handle
                name-defining at-rules in shadow DOM. This change
                should improve interoperability if other browsers
                agree to implement the spec.



                Gecko: No signal
                (https://github.com/mozilla/standards-positions/issues/556
                <https://github.com/mozilla/standards-positions/issues/556>)

                WebKit: No signal
                
(https://lists.webkit.org/pipermail/webkit-dev/2021-July/031926.html
                
<https://lists.webkit.org/pipermail/webkit-dev/2021-July/031926.html>)

                Web developers: Strongly positive
                (https://bugs.chromium.org/p/chromium/issues/detail?id=336876
                <https://bugs.chromium.org/p/chromium/issues/detail?id=336876>)
                While the crbug is only for @font-face, we are aiming
                at consistent handling of all the name-defining
                at-rules, including @counter-style.


                        Debuggability

                N/A; it's an extension to an already shipped feature,
                @counter-style. Note that we don't have DevTools
                support for @counter-style yet, as the requirement was
                imposed after @counter-style was shipped.



                        Is this feature fully tested by
                        web-platform-tests
                        
<https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md>?

                Yes


                        Flag name

                --enable-blink-features=CSSAtRuleCounterStyleInShadowDOM


                        Requires code in //chrome?

                No


                        Tracking bug

                https://bugs.chromium.org/p/chromium/issues/detail?id=1225033
                <https://bugs.chromium.org/p/chromium/issues/detail?id=1225033>


                        Link to entry on the Chrome Platform Status

                https://chromestatus.com/feature/5716198446596096
                <https://chromestatus.com/feature/5716198446596096>


                        Links to previous Intent discussions

                Intent to prototype:
                
https://groups.google.com/a/chromium.org/g/blink-dev/c/vSPTU15iL9Y/m/jNYWijNmAgAJ
                
<https://groups.google.com/a/chromium.org/g/blink-dev/c/vSPTU15iL9Y/m/jNYWijNmAgAJ>


                This intent message was generated by Chrome Platform
                Status <https://www.chromestatus.com/>.
-- You received this message because you are subscribed
                to the Google Groups "blink-dev" group.
                To unsubscribe from this group and stop receiving
                emails from it, send an email to
                blink-dev+unsubscr...@chromium.org
                <mailto:blink-dev+unsubscr...@chromium.org>.
                To view this discussion on the web visit
                
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFqEGhbX3YhbNHMd4DBaf%3DsK5pk9H88O5zf%2BR4fv6KJsrLdxMQ%40mail.gmail.com
                
<https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFqEGhbX3YhbNHMd4DBaf%3DsK5pk9H88O5zf%2BR4fv6KJsrLdxMQ%40mail.gmail.com?utm_medium=email&utm_source=footer>.

-- You received this message because you are subscribed to the
        Google Groups "blink-dev" group.
        To unsubscribe from this group and stop receiving emails from
        it, send an email to blink-dev+unsubscr...@chromium.org
        <mailto:blink-dev+unsubscr...@chromium.org>.
        To view this discussion on the web visit
        
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFqEGha5GaYxbhcwrhAfCp1n2-BX3UEVOqVYAJ5Nv8MpbBSExA%40mail.gmail.com
        
<https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFqEGha5GaYxbhcwrhAfCp1n2-BX3UEVOqVYAJ5Nv8MpbBSExA%40mail.gmail.com?utm_medium=email&utm_source=footer>.

--
You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org <mailto:blink-dev+unsubscr...@chromium.org>. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfU3MavxU2Ne4tMr6qcmSVGPMy2S7J6GCurrsnjHUdCmwA%40mail.gmail.com <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfU3MavxU2Ne4tMr6qcmSVGPMy2S7J6GCurrsnjHUdCmwA%40mail.gmail.com?utm_medium=email&utm_source=footer>.

--
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/98c00b8a-ee7c-bd20-6655-f06a9b459c76%40gmail.com.

Reply via email to