Good morning Luke,
> All attempts are harmful, no matter the intent, in that they waste > contributors' time that could be better spent on actual development. > > However, I do also see the value in studying and improving the review process > to harden it against such inevitable attacks. The fact that we know the NSA > engages in such things, and haven't caught one yet should be a red flag. Indeed, I believe we should take the position that "review process is as much a part of the code as the code itself, and should be tested regularly". > Therefore, I think any such a scheme needs to be at least opt-out, if not > opt-in. Please ensure there's a simple way for developers with limited time > (or other reasons) to be informed of which PRs to ignore to opt-out of this > study. (Ideally it would also prevent maintainers from merging - maybe > possible since we use a custom merging script, but what it really needs to > limit is the push, not the dry-run.) Assuming developers are normal humans with typical human neurology (in particular a laziness circuit), perhaps this would work? Every commit message is required to have a pair of 256-bit hex words. Public attempts at attack / testing of the review process will use the first 256-bit as a salt, and when the salt is prepended to the string "THIS IS AN ATTACK" and then hashed with e.g. SHA256, should result in the second 256-bit word. Non-attacks / normal commits just use random 256-bit numbers. Those opting-out to this will run a script that checks commit messages for whether the first 256-bit hexword concatenated with "THIS IS AN ATTACK", then hashed, is the second 256-bit hexword. Those opting-in will not run that script and ignore the numbers. The script can be run as well at the maintainer. Hopefully, people who are not deliberately opting out will be too lazy to run the script (as is neurotypical for humans) and getting "spoilered" on this. ***HOWEVER*** We should note that a putative NSA attack would of course not use the above protocol, and thus no developer can ever opt out of an NSA attempt at inserting vulnerabilities; thus, I think it is better if all developers are forced to opt in on the "practice rounds", as they cannot opt out of "the real thing" other than to stop developing entirely. Regards, ZmnSCPxj _______________________________________________ bitcoin-dev mailing list bitcoin-dev@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev
