Hi Gleb,
Minor feedback on reading the draft:
> sendrecon:
> uint32 version Must be exactly 1 currently.
At risk of quoting myself[1]: data doesn't have requirements. Actors do.
In this case, I assume you mean "writers must set this to 1". What do
readers do if it's not?
> reqreconcil
> uint8 q Coefficient used to estimate set difference.
You describe how to calculate q (as a floating point value), but not how
to encode it?
> Every node stores sets of 128-bit truncated IDs per every peer
"*a* set..." or is it "two sets" (if you include the snapshot?).
And " *for* every peer" (maybe "which supports tx reconciliation?")
> To the best of our knowledge, PinSketch is more bandwidth efficient
> than IBLT, especially for the small differences in sets we expect to
> operate over.
Remove "To the best of our knowledge, ": that makes it sound like it's
up for debate. I've implemented and experimented with IBLT, and it's
worse.
Cheers,
Rusty.
[1]
https://github.com/lightningnetwork/lightning-rfc/blob/master/CONTRIBUTING.md#writing-the-requirements
_______________________________________________
bitcoin-dev mailing list
bitcoin-dev@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev
