Hello Olivier, this is weird and also embarassing. Gonna check asap. Sorry for that.
Maria On Fri, Apr 04, 2025 at 10:06:39AM +0200, Olivier Cochard-Labbé wrote: > Hi Maria, > > Sorry to bother you again. > > The release 3.1.0 still doesn’t build on FreeBSD with the same Netlink > error. > > sysdep/bsd-netlink/netlink.c:1873:30: error: no member named 'nh' in > 'struct ea_list' > 1873 | if (krt_assume_onlink(ra->nh.iface, ipa_is_ip6(ra->nh.gw > ))) > | ~~ ^ > sysdep/bsd-netlink/netlink.c:1873:55: error: no member named 'nh' in > 'struct ea_list' > 1873 | if (krt_assume_onlink(ra->nh.iface, ipa_is_ip6(ra->nh.gw > ))) > | ~~ ^ > ./lib/ip.h:103:42: note: expanded from macro 'ipa_is_ip6' > 103 | #define ipa_is_ip6(a) (! ip6_is_v4mapped(a)) > | ^ > sysdep/bsd-netlink/netlink.c:1874:10: error: no member named 'nh' in > 'struct ea_list' > 1874 | ra->nh.flags |= RNF_ONLINK; > | ~~ ^ > > Regards, > > Olivier > > On Sat, Jan 11, 2025 at 12:42 PM Maria Matejka <maria.mate...@nic.cz> wrote: > > > The real problem is a combination of a different nexthop structure and a > > missing build autotest for FreeBSD-Netlink. > > > > Gonna fix both probably on Monday. > > > > Sorry for this, we forgot to add a build test when merging bsd netlink and > > now it backfires. > > > > Thank you for the report! > > Maria > > > > > > On 11 January 2025 12:17:19 CET, Marek Zarychta via Bird-users < > > bird-users@network.cz> wrote: > > > >> W dniu 11.01.2025 o 12:01, Olivier Cochard-Labbé pisze: > >> > >> Hi, > >> > >> bird 3.0.1 include this patch: "Netlink: Handle onlink flag on > >> BSD-Netlink" > >> > >> https://gitlab.nic.cz/labs/bird/-/commit/f9c7861e116ad8dc5e5a2314d0f976bf8c938de0 > >> > >> But this broke FreeBSD build with this error: > >> sysdep/bsd-netlink/netlink.c:1868:10: error: no member named 'nh' in > >> 'struct ea_list > >> > >> Regards, > >> Olivier > >> > >> It looks like the real culprit is > >> > >> > >> https://gitlab.nic.cz/labs/bird/-/commit/5c3eff5645446cddb082130feda8298322f576c2 > >> > >> -- > >> Marek Zarychta > >> > >> -- > > Maria Matejka (she/her) | BIRD Team Leader | CZ.NIC, z.s.p.o. > > -- Maria Matejka (she/her) | BIRD Team Leader | CZ.NIC, z.s.p.o.
