BGP: connect delay timer vs connect retry timer

[Bala Sajja]

Hi,
   It seems where BGP connect retry timer to be kicked in use cases
also, connect delay timer gets kicked in. In the below function,
though bgp_setup_conn(p, conn) sets connect_timer to connect retry
timer, later it's over written by bgp_start_timer(conn->connect_timer,
delay) which  sets connect_timer to connect delay timer. Is this right
? Could we make the connect retry timer work properly ?

bgp_active(struct bgp_proto *p)
{
  int delay = MAX(1, p->cf->connect_delay_time);
  struct bgp_conn *conn = &p->outgoing_conn;

  BGP_TRACE(D_EVENTS, "Connect delayed by %d seconds", delay);
  bgp_setup_conn(p, conn);
  bgp_conn_set_state(conn, BS_ACTIVE);
  bgp_start_timer(conn->connect_timer, delay);
}


Regards,
Bala.