Robert Scheck <b...@robert-scheck.de> writes:
> On Mon, 03 Feb 2020, Toke Høiland-Jørgensen wrote:
>> I think the below patch (against master) ought to fix it? Don't have a
>> GCC v10 handy to test with, but at least it doesn't seem to break
>> anything on GCC v9 :)
>>
>> I think the same patch ought to apply against Bird 2.0.7 as well...
>
> https://koji.fedoraproject.org/koji/taskinfo?taskID=41348829 - yes, looks
> good (also on RHEL/CentOS/EPEL 7 with old GCC 4.8.5).
Great! And thanks for fixing the Fedora package!
> I wouldn't have expected that the patch is that trivial when working
> on other packages/ software before.
Heh, no, me neither :)
>> diff --git a/nest/route.h b/nest/route.h
>> index d2a07f09..b927db5f 100644
>> --- a/nest/route.h
>> +++ b/nest/route.h
>> @@ -458,7 +458,7 @@ typedef struct rta {
>> protocol-specific metric is
>> availabe */
>>
>>
>> -const char * rta_dest_names[RTD_MAX];
>> +extern const char * rta_dest_names[RTD_MAX];
>>
>> static inline const char *rta_dest_name(uint n)
>> { return (n < RTD_MAX) ? rta_dest_names[n] : "???"; }
>
> Could upstream please merge this to master and the next release?
> Thanks.
+1. Let me know if you want me to send a proper patch (but this is
probably so trivial so it's easier for you guys to just add it
yourself).
-Toke
