Ondrej Zajicek <santi...@crfreenet.org> writes: > On Fri, Jul 13, 2018 at 10:16:16PM +0200, Toke Høiland-Jørgensen wrote: >> This implements support for HMAC verification in Babel, as specified by >> draft-do-babel-hmac-00. > > Hi > > Thanks, will check that. One minor issue i just noticed (other than > getrandom()) is that with BABEL_TLV_MAX increase we have significantly > larger tlv_data full of zeros.
Well, as the draft progresses further it is going to get TLV numbers assigned that are lower than what is used currently, so that issue should go away by then. > Also, am i understand it correctly that spec allows index of any size, > while this implementation limits it to 10 bytes? Yup; but if I get my way, that will change in the draft as well. See https://mailarchive.ietf.org/arch/msg/babel/NJjQh1phkpJe8OSSdEz4FqqyfVU and the discussion that follows. -Toke
