codetools already checks only closures in checkUsageENv and hande checkUsagePackage, so this is anissue on the Bioc side.
Best, luke On Tue, 18 Dec 2018, Tierney, Luke wrote: > Codetools should probably be ignoring those. Will have a look > > Sent from my iPhone > >> On Dec 18, 2018, at 6:54 AM, Shepherd, Lori <lori.sheph...@roswellpark.org> >> wrote: >> >> Can you please open an issue for this so we don't lose track of it - >> >> https://github.com/Bioconductor/BiocCheck/issues >> >> >> >> Lori Shepherd >> >> Bioconductor Core Team >> >> Roswell Park Cancer Institute >> >> Department of Biostatistics & Bioinformatics >> >> Elm & Carlton Streets >> >> Buffalo, New York 14263 >> >> ________________________________ >> From: Bioc-devel <bioc-devel-boun...@r-project.org> on behalf of Shian Su >> <s...@wehi.edu.au> >> Sent: Monday, December 17, 2018 8:34:10 PM >> To: bioc-devel >> Subject: [Bioc-devel] Aliasing `]` breaks BiocCheck::BiocCheck() version >> 1.18.0 >> >> Hi all, >> >> If you put >> >> foo <- `[` >> >> Somewhere in a package, it will trigger >> >> Error in makeUsageCollector(fun, ...) : only works for closures >> >> In BiocCheck::BiocCheck() (version 1.18.0). This comes from >> >> if (typeof(fun) != "closure") >> stop("only works for closures") >> >> In codetools::makeUsageCollector(), but >> >>> typeof(`[`) >> ## "special" >> >> Not that it matters for my use-case because I had discovered magrittr???s >> extract alias, but it might be an edge case worth covering, especially since >> the error message is so cryptic. >> >> Kind regards, >> Shian Su >> >> _______________________________________________ >> >> The information in this email is confidential and intend...{{dropped:29}} >> >> _______________________________________________ >> Bioc-devel@r-project.org mailing list >> https://stat.ethz.ch/mailman/listinfo/bioc-devel > _______________________________________________ > Bioc-devel@r-project.org mailing list > https://stat.ethz.ch/mailman/listinfo/bioc-devel -- Luke Tierney Ralph E. Wareham Professor of Mathematical Sciences University of Iowa Phone: 319-335-3386 Department of Statistics and Fax: 319-335-3017 Actuarial Science 241 Schaeffer Hall email: luke-tier...@uiowa.edu Iowa City, IA 52242 WWW: http://www.stat.uiowa.edu _______________________________________________ Bioc-devel@r-project.org mailing list https://stat.ethz.ch/mailman/listinfo/bioc-devel
