Lorenzo Caggioni wrote:
> Attached you can find the code an a input file to try it.
> 
> I'm sorry if the code is not realy commented and if it is no real clear, but
> i have to delete some line because it is base on a database....
> 
> Now the program can run without any DB.
> You can find even a profile for the program.

Others have mentioned optimizations but I noticed a few errors:

     89     if ($InvalidReason eq undef)

You can not use the value undef in a comparison, that should be:

    if ( ! defined $InvalidReason )

And:

    311     @{$inputCDR_HASH{"0"}} = @{$xInputCDR} if $xInputCDR != undef;

    @{$inputCDR_HASH{"0"}} = @{$xInputCDR} if defined $xInputCDR;



    392     return $globalParameters{"GNV_INTERF_MODIFIER"}{"11"}{"NATTLG"} if
$xServiceCode = 9510;
    393     return $globalParameters{"GNV_INTERF_MODIFIER"}{"10"}{"INTTLG"} if
$xServiceCode = 9520;

If you had warnings enabled then perl would have warned you that you are doing
an asignment instead of a comparison.  You should have these two lines at the
beginning of your program:

use warnings;
use strict;



John
-- 
use Perl;
program
fulfillment

-- 
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
<http://learn.perl.org/> <http://learn.perl.org/first-response>


Reply via email to