>>>>> "Jason" == Jason Corbett <[EMAIL PROTECTED]> writes:

Jason> our ($dbh);  #
Jason> our (@files);  #
Jason> our ($filename); #
Jason> our ($errorlog); #logs all successes and failures of the report
Jason> our ($dirfolder); #where the treatment report is sent prior to emailing
Jason> our (@record);  #holds all records returned from query
Jason> our ($success_var); #flags the script if completion was successful or not
Jason> our ($sql);  #
Jason> our ($sth);  #
Jason> our ($dayreport); #
Jason> our ($process_date); #used in the log file to tell what date and time a file 
complete or failed
Jason> our ($month);  #
Jason> our ($day);  #
Jason> our ($year);  #
Jason> our ($truename); #Time stamps the name of each treatment report AFTER the 
GENERIC name is changed
Jason> our (@times);  #Helps Timestamp the treatment reports each day
Jason> our ($reportlog); #Folder for keeping up with all Treatment reports
Jason> our ($fourdayreport); #the path that leads to the location of the generic 4 day 
report
Jason> our ($recordlist); #allows the for manipulation of data retrieved from query

This script is already unmaintainable for me.

Far too many global variables, and some with names that suggest
related usage, but aren't connected.

Just feedback.

-- 
Randal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095
<[EMAIL PROTECTED]> <URL:http://www.stonehenge.com/merlyn/>
Perl/Unix/security consulting, Technical writing, Comedy, etc. etc.
See PerlTraining.Stonehenge.com for onsite and open-enrollment Perl training!

-- 
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
<http://learn.perl.org/> <http://learn.perl.org/first-response>


Reply via email to