Andrea Holstein wrote: > In article <[EMAIL PROTECTED]> wrote "Chris" <[EMAIL PROTECTED]>: > > >>>... >>> >>Thanks! >> >>... >> my $newresult = $result; >> print "New Results - $$newresult\n"; >> my $resultcode; >> print "Result Code - $$resultcode;\n"; >> if ($newresult = 200) { >> > > Take Care: You surely meant > if ($newresult == 200) { ... } > > (if ($newresult = 200) means > assign 200 to $newresult, > and go into the if-statement if another value than 0 > was assigned, what is the fact > ) > >> $resultcode = "Code 200 - '\n"; >> } elsif ($newresult = 400) { >> $resultcode = "Code 400 - Bad Request\n"; >> } elsif ($newresult = 403) { >> $resultcode = "Code 403 - Forbidden\n"; >> } elsif ($newresult = 404) { >> $resultcode = "Code 404 - Not Found\n"; >> } elsif ($newresult = 405) { >> $resultcode = "Code 405 - Method Not Allowed\n"; >> } elsif ($newresult = 406) { >> $resultcode = "Code 406 - Not Acceptable\n"; >> } elsif ($newresult = 407) { >> $resultcode = "Code 407 - Proxy Authentication Required\n"; >> } elsif ($newresult = 408) { >> $resultcode = "Code 408 - Request Timeout\n"; >> } elsif ($newresult = 409) { >> $resultcode = "Code 409 - Conflict\n"; >> } elsif ($newresult = 410) { >> $resultcode = "Code 410 - Gone\n"; >> } elsif ($newresult = 500) { >> $resultcode = "Code 500 - Internal Server Error\n"; >> } elsif ($newresult = 501) { >> $resultcode = "Code 501 - Not Implemented\n"; >> } elsif ($newresult = 502) { >> $resultcode = "Code 502 - Bad Gateway\n"; >> } elsif ($newresult = 503) { >> $resultcode = "Code 503 - Service Unavailable\n"; >> } elsif ($newresult = 504) { >> $resultcode = "Code 504 - Gateway Timeout\n"; >> } elsif ($newresult = 505) { >> $resultcode = "Code 505 - HTTP Version Not Supported\n"; >> } else { >> $resultcode = "Unknown error...\n"; >> } >> print "\nNew Results Code - $resultcode\nNew Results - >>$newresult\nOld Results - $result"; >> print DUMPFILE "* $result\n"; >> print DUMPFILE "*\n"; >> close (DUMPFILE); >> >> > > I couldn't believe you really typed it in. > Every second line is reduntant (it must be VB-style:-)) > > However, I'd suggest a solution with a hash: > my %code_desc = ( > 200 => 'Access successful', > 400 => 'Bad Request', > 403 => 'Forbidden', > ... > ); > > Then your code becomes much shorter: > $resultcode = $code_desc{$newresult} > ? "Code $newresult - $code_desc{$newresult}\n" > : "Unknown Error"; > > --- > > Of course, if you are so lazy like me, > you can reduce the effort to define the hash, too: > > my %code_desc = map {/(\d+) (.*)/; ($1 => $2}} spit /\n/, <<DESCRIPTION; > 200 Access successful > 400 Bad Request > 403 Forbidden > .. > DESCRIPTION > > > Best Wishes, > Andrea > >
Yes it IS a VBism! :) I am still learning Perl. Will save your comments off, for once I have a better understanding of what it is they are doing, and so that I can then take full advantage of them!!! Thanks... :) :) :) -- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
