Hi Shlomi. A reminder that sometimes when somebody does something, you can just ignore the email and _not_ reply to it.
Thanks, John the list mom. -- John Anderson // j...@genehack.org > On Jun 7, 2018, at 08:58, Shlomi Fish <shlo...@shlomifish.org> wrote: > > Hi, > > why did you resurrect a one year old's thread for which there were proper > replies here - > https://www.nntp.perl.org/group/perl.beginners/2017/05/msg126502.html and here > - https://github.com/shlomif/project-euler/tree/master/project-euler/8 . just > let sleeping dogs rest. Some comments on your code: > > On Wed, 06 Jun 2018 19:23:11 -0700 > "John W. Krahn" <jwkr...@shaw.ca> wrote: > >> On Tue, 2017-05-16 at 14:01 +0800, derr...@thecopes.me wrote: >> >> >> I am working on problem #8 of the euler project. see below. >>> >>> >>> >>> The four adjacent digits in the 1000-digit number that have the >>> greatest product are 9 × 9 × 8 × 9 = 5832. >>> >>> 73167176531330624919225119674426574742355349194934 >>> 96983520312774506326239578318016984801869478851843 >>> 85861560789112949495459501737958331952853208805511 >>> 12540698747158523863050715693290963295227443043557 >>> 66896648950445244523161731856403098711121722383113 >>> 62229893423380308135336276614282806444486645238749 >>> 30358907296290491560440772390713810515859307960866 >>> 70172427121883998797908792274921901699720888093776 >>> 65727333001053367881220235421809751254540594752243 >>> 52584907711670556013604839586446706324415722155397 >>> 53697817977846174064955149290862569321978468622482 >>> 83972241375657056057490261407972968652414535100474 >>> 82166370484403199890008895243450658541227588666881 >>> 16427171479924442928230863465674813919123162824586 >>> 17866458359124566529476545682848912883142607690042 >>> 24219022671055626321111109370544217506941658960408 >>> 07198403850962455444362981230987879927244284909188 >>> 84580156166097919133875499200524063689912560717606 >>> 05886116467109405077541002256983155200055935729725 >>> 71636269561882670428252483600823257530420752963450 >>> >>> Find the thirteen adjacent digits in the 1000-digit number that have >>> the greatest product. What is the value of this product? >> >> >> >> #!/usr/bin/perl >> use warnings; >> use strict; >> >> ( my $x = <<STUFF ) =~ s/\s+//g; > > Please use a more meaninful var name. > >> 73167176531330624919225119674426574742355349194934 >> 96983520312774506326239578318016984801869478851843 >> 85861560789112949495459501737958331952853208805511 >> 12540698747158523863050715693290963295227443043557 >> 66896648950445244523161731856403098711121722383113 >> 62229893423380308135336276614282806444486645238749 >> 30358907296290491560440772390713810515859307960866 >> 70172427121883998797908792274921901699720888093776 >> 65727333001053367881220235421809751254540594752243 >> 52584907711670556013604839586446706324415722155397 >> 53697817977846174064955149290862569321978468622482 >> 83972241375657056057490261407972968652414535100474 >> 82166370484403199890008895243450658541227588666881 >> 16427171479924442928230863465674813919123162824586 >> 17866458359124566529476545682848912883142607690042 >> 24219022671055626321111109370544217506941658960408 >> 07198403850962455444362981230987879927244284909188 >> 84580156166097919133875499200524063689912560717606 >> 05886116467109405077541002256983155200055935729725 >> 71636269561882670428252483600823257530420752963450 >> STUFF >> >> my @z = ( 0 ) x 5; > > why 5? >> while ( $x =~ / ( . ) (?= ( . ) ( . ) ( . ) ( . ) ( . ) ( . ) ( . ) ( . >> ) ( . ) ( . ) ( . ) ( . ) ) /xg ) { >> my $y = $1 * $2 * $3 * $4 * $5 * $6 * $7 * $8 * $9 * $10 * $11 * >> $12 * $13; >> @z = ( $1, $2, $3, $4, $5, $6, $7, $8, $9, $10, $11, $12, $13, $y ) >> if $z[ -1 ] < $y; >> } >> > > this code is full of duplicate functionality and you are abusing the capture > vars as arrays. > > The ?= trick is nice, though. > >> print "@z\n"; >> >> >> __END__ >> > > -- > To unsubscribe, e-mail: beginners-unsubscr...@perl.org > For additional commands, e-mail: beginners-h...@perl.org > http://learn.perl.org/ > > -- To unsubscribe, e-mail: beginners-unsubscr...@perl.org For additional commands, e-mail: beginners-h...@perl.org http://learn.perl.org/
