Hi David,
On Thu, 13 Jun 2013 21:30:00 -0700
David Christensen <dpchr...@holgerdanske.com> wrote:
> On 06/13/13 01:41, Shlomi Fish wrote:
> > 1. You're lacking strict and warnings:
> > 2. You're looping using $_ :
> > 3. You're using md5_hex by slurping the contents of the file into memory,
> > 4. read_file was not explictly imported from File::Slurp:
> > Both the Perl Cookbook and Programming Perl are showing their age.
>
> I have different quality metrics/ expectations for one-liners turned
> into scripts than I do for large-scale multi-person systems software
> products:
That's nice and dandy, but please don't publish the products of your
"one-liners turned into scripts" here without cleaning them up first, because
there are beginners on this mailing list who need to learn good practices from
the code and posts here, and code such as yours encourages bad practices.
People may also find code like that by web search which will further set back
the pedagogic level.
You've also wasted my time in me having to comment on your post, and yours in
having to comment on my response to yours. <sigh />
Regards,
Shlomi Fish
--
-----------------------------------------------------------------
Shlomi Fish http://www.shlomifish.org/
Buffy Factoids - http://www.shlomifish.org/humour/bits/facts/Buffy/
Chuck Norris has 0 messages in his E-mail inbox. Including already read ones.
— http://www.shlomifish.org/humour/bits/facts/Chuck-Norris/
Please reply to list if it's a mailing list post - http://shlom.in/reply .
--
To unsubscribe, e-mail: beginners-unsubscr...@perl.org
For additional commands, e-mail: beginners-h...@perl.org
http://learn.perl.org/
