>>>>> "JWK" == John W Krahn <jwkr...@shaw.ca> writes:
JWK> Andreas Moroder wrote: >> Hello, JWK> Hello, >> I have found a nice utility >> http://www.novell.com/communities/node/389/adm+file+utilities+2+5 >> that has two problems: JWK> has *many* problems. s/many/a gazillion/ ; JWK> 3) No use of warnings or strictures. JWK> 4) There is no error checking for system calls. JWK> 5) It is Perl4 code from 8 years ago. that code is an abomination. one quick bug is the GetDir recursive descent sub to get all dirs doesn't check for symlinks so it can easily fall into an infinite recursion. the abuse of undef() is beyond bad nor needed. and as john said, it is perl4 code which means it is about 15 years old. it should never be installed or used anywhere. also it says it is for winblows activestate perl so it would never be easily ported to unix as it assumes \ everywhere for dir separators. also most/all of it is available in portable modules on cpan. it seems to more interested in integrating into some winblows gui toy than doing real work. so if you want to learn good perl code, look at that and see what really BAD perl code is like. especially bad perl4 code. uri -- Uri Guttman ------ u...@stemsystems.com -------- http://www.sysarch.com -- ----- Perl Code Review , Architecture, Development, Training, Support ------ --------- Gourmet Hot Cocoa Mix ---- http://bestfriendscocoa.com --------- -- To unsubscribe, e-mail: beginners-unsubscr...@perl.org For additional commands, e-mail: beginners-h...@perl.org http://learn.perl.org/
