Thanks to all that assisted in this thread. I think I am now getting
where I want to go with using hashes. One comment that I could use
clarification on is:
JR(> for ( $i=0; $i <= $number_of_elements-1; $i++ ) {
don't loop over indices, loop over the data.
JR(> $element = (split /,/, $_)[$i];
What is meant by don't loop over indices, loop over the data? Isn't the
purpose of the indice to control how many times you loop?
-----Original Message-----
From: Uri Guttman [mailto:u...@stemsystems.com]
Sent: Friday, September 25, 2009 1:58 PM
To: Johnson, Reginald (GTS)
Cc: beginners@perl.org
Subject: Re: hash question
>>>>> "JR(" == Johnson, Reginald (GTS) <reggie_john...@ml.com> writes:
JR(> Sample input file "test2,MS-Windows-NT,Silver,NPRO30DINCR,Client
JR(> JXWGTI7R5CHD1 WINDOWS NT,Schedule test2_full_1700 FULL 604800"
JR(> print "Enter the filename of input file with full path\n";
JR(> my $input_file = <>;
JR(> chomp($input_file);
JR(> # check to see if input file exist
JR(> if ( -e $input_file) {
JR(> open( INFILE, "<", "$input_file") or
JR(> die "$input_file does not exists: $!";
JR(> }
the -e check and the open/die are redundant. drop the -e as you don't
need it.
JR(> my %policy_Hash=();
no need to initialize a hash to () as my does that.
JR(> my ($parameters);
declare vars as they are used.
JR(> while (<INFILE>) {
JR(> my @n = split /,/, $_;
JR(> my $number_of_elements = scalar @n;
JR(> print scalar @n, "\n";
why do you not use $number_of_elements since you just go it?
JR(> my ($policy_name,$i,$element);
JR(> ($policy_name,$parameters) = split( /,/, $_, 2 );
JR(> print "policy_name = $policy_name has $number_of_elements
elements\n";
JR(> for ( $i=0; $i <= $number_of_elements-1; $i++ ) {
don't loop over indices, loop over the data.
JR(> $element = (split /,/, $_)[$i];
you split the whole line on , so that split won't do anything
JR(> print "this is element i=$i $element\n";
JR(> $policy_Hash{$policy_name}{
'element_$i'}=
JR(> (split /,/, $_)[$i];
here is your main bug. '' won't interpolate $i. use "" for that. this is
assigning each value to the same hash element and overwriting the
previous one. learn to use Data::Dumper to see what is really in your
hash.
JR(> This message w/attachments (message) may be privileged,
confidential or proprietary, and if you are not an intended recipient,
please notify the sender, do not use or share it and delete it. Unless
specifically indicated, this message is not an offer to sell or a
solicitation of any investment products or other financial product or
service, an official confirmation of any transaction, or an official
statement of Merrill Lynch. Subject to applicable law, Merrill Lynch may
monitor, review and retain e-communications (EC) traveling through its
networks/systems. The laws of the country of each sender/recipient may
impact the handling of EC, and EC may be archived, supervised and
produced in countries other than the country in which you are located.
This message cannot be guaranteed to be secure or error-free. References
to "Merrill Lynch" are references to any company in the Merrill Lynch &
Co., Inc. group of companies, which are wholly-owned by Bank of America
Corporation. Securities and Insurance Products: * Are Not FDIC Insured *
Are Not Bank Guaranteed * May Lose Value * Are Not a Bank Deposit * Are
Not a Condition to Any Banking Service or Activity * Are Not Insured by
Any Federal Government Agency. Attachments that are part of this
E-communication may have additional important disclosures and
disclaimers, which you should read. This message is subject to terms
available at the following link:
http://www.ml.com/e-communications_terms/. By messaging with Merrill
Lynch you consent to the foregoing.
that disclaimer is longer than your code!
uri
--
To unsubscribe, e-mail: beginners-unsubscr...@perl.org
For additional commands, e-mail: beginners-h...@perl.org
http://learn.perl.org/
