212 open(RPT, ">>$REPORT") or die "Can't open $REPORT: $!"; ... 221 system "echo \"Starting WKI clone process for $DATE on `date`\" >> $REPORT"; So you open $REPORT for appending, and then echo into it? Why open it in the first place? Also, it seems a bit risky, especially since the RPT filehandle is not autoflushed. (The $|=1 at the neginning of the script does this for STDOUT, but not for any filehandle you open.) And backticks inside a system call is not quite Perlish enough for my taste. I would change line 221 to print RPT "Starting WKI clone process for $DATE on ", scalar(localtime), "\n"; And to be tidy: close RPT; when you're done writing to it. -- tdk
- Re: REVIEW: please review the following John Joseph Trammell
- Re: REVIEW: please review the following Peter Scott
- Re: REVIEW: please review the following Kevin Meltzer
- RE: REVIEW: please review the following Yacketta,Ronald J
- RE: REVIEW: please review the following Yacketta,Ronald J
- RE: REVIEW: please review the following Jeff Pinyan
- RE: REVIEW: please review the following Jeff Pinyan
- RE: REVIEW: please review the following Peter Scott
- RE: REVIEW: please review the following Paul
- RE: REVIEW: please review the following Yacketta,Ronald J
- RE: REVIEW: please review the following Timothy Kimball
- RE: REVIEW: please review the following Yacketta,Ronald J
- RE: REVIEW: please review the following Yacketta,Ronald J
- RE: REVIEW: please review the following Jeff Pinyan
- RE: REVIEW: please review the following Peter Scott
- RE: REVIEW: please review the following Yacketta,Ronald J
- RE: REVIEW: please review the following Wagner-David