On Tue, Jul 09, 2024 at 09:59:54AM +0200, Daniele Nicolodi wrote: > As you can see, some methods have been renamed. The other important change, > is that beangulp.Importer is now an ABC, thus the implementation will check > that any subclass implements the expected interface when it is instantiated. > > At a quick look, it seems that you changed your importers base class from > deriving from beancount.ingest.ImporterProtocol (or similar, I don't > remember the exact import path) to beangulp.Importer but kept the > implementation unchanged. This is not expected to work.
That was exactly my issue. I failed to isolate it as root cause as I mixed this change with the one discussed previously in the thread. Chaning my class inheritance back to beancount.ingest.importer.ImporterProtocol fixed the issue. I now have a working setup based on v3. (But I'm going to upgrade to the new protocol anyway, as the new warnings are conspicuous enough :-)) In case there is somewhere a migration guide from v2 ingest to v3 beangulp, this ought to be noted down for others. (I would have probably given up myself on this without your help.) Thanks a lot! Cheers -- Stefano Zacchiroli . z...@upsilon.cc . https://upsilon.cc/zack _. ^ ._ Full professor of Computer Science o o o \/|V|\/ Télécom Paris, Polytechnic Institute of Paris o o o </> <\> Co-founder & CTO Software Heritage o o o o /\|^|/\ https://twitter.com/zacchiro . https://mastodon.xyz/@zacchiro '" V "' -- You received this message because you are subscribed to the Google Groups "Beancount" group. To unsubscribe from this group and stop receiving emails from it, send an email to beancount+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/beancount/20240709185433.xq2u3wr3jeh736ta%40upsilon.cc.
