On Monday, March 23, 2020 at 4:13:57 PM UTC-7, Dave The Happy Singer wrote: > > > If you're interested in contributing code to do this, please do, by all > means. An irr directory within fava-investor on a dev branch would be a > great if you already have working code and tests. If not, feel free to > point me to your code. > > OK, as soon as work allows, I'll either make my repo public for you to > look at or fork fava-investor with a dev branch. My project is currently > set up as an installable python package (albeit not on public pypi yet as I > considered it pre-release, so I might go with opening the repo just so you > can see if it's suitable for contributing. >
Sounds good, I look forward to it! > >> I very much agree with the philosophy of library/cli/fava. >> > > >> However, I find that for investing reports and tools, interactivity and >> visualization are key. This is the reason I'd like to build this primarily >> as a fava extension, >> > > All good! Contribution guidelines and code review can help us contribute > code that can be reusable in a library or cli context, I think, just wanted > to flag up my strong support for having those APIs available and designed > in along the way if possible, e.g. by keeping fava-specific code separate > from generic beancount-level implementation, we will be in a good position. > Contribution guidelines and reviews are a great place to enforce the APIs, will do :). -- You received this message because you are subscribed to the Google Groups "Beancount" group. To unsubscribe from this group and stop receiving emails from it, send an email to beancount+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/beancount/7202fb5b-5ae9-4888-b303-25caa9296bda%40googlegroups.com.
