On Wednesday, March 11, 2020 at 2:43:55 AM UTC-7, Justus Pendleton wrote: > > It looks like if account_field is set to LEAF(account) then the URLs for > the accounts are broken -- they take you to my-personal-ledger/account/LEAF > instead of my-personal-ledger/account/Assets:Tree:Leaf >
I noticed this as well. I assume fava is adding this link if the column is named 'account'. I'll figure out a fix later. > There's something wrong in how it collects the holdings. The command line > version generates the correct set of holdings but the fava version also > includes some lots that I sold last week. I haven't looked yet to figure > out why they are being included. > Ah, I included 'date <= DATE_ADD(TODAY(), -30)' in the fava version, to filter out purchases within the past 30 days since they cause washes. I realize now that is incorrect, since that (incorrectly) filters out sales during the last 30 days as well. I should include them in both the holdings and in the wash sales. Fix committed. Thanks for spotting this! > The "purchases within the past 30 days" doesn't include purchases I made, > it only includes sales I made. I think it is supposed to be the other way > around? > This needed a fix as well. Not sure why it doesn't include the purchases, but I added 'number>0' in the query to filter out sales. Would you mind trying again? Lesson: the queries pack a lot of assumptions into a dense SQL-like statement, and I'd not be surprised if there're a few more cases hiding. I'll soon commit a unit test to make this easier. Thank you very much for test driving this and the helpful feedback! -- You received this message because you are subscribed to the Google Groups "Beancount" group. To unsubscribe from this group and stop receiving emails from it, send an email to beancount+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/beancount/43a22ede-05db-4252-8018-f2670d945bc1%40googlegroups.com.
