On Thu, Mar 29, 2018 at 08:30:30PM -0400, Martin Blais wrote: > You speak as if a little bit of untested code is worth anything. It's > not. Let me explain.
Oh, no, I agree it's not worth it. And it's great that you, as Beancount maintainer, have high standards for code acceptance that encompass: (1) not breaking existing tests, and (2) having thorough unit tests for the new code being contributed. But it seems to me that that is almost completely unrelated to the choice of hosting platform, isn't it? Aren't you in fact just saying that what you want is continuous integration (CI) integrated with the contribution work-flow for proposed patches? Both GitLab and GitHub have integrated CI offerings, and IME they go a long way in avoiding wasting maintainer time in "complaining" about breaking existing tests. You make the CI run on incoming patches, if existing tests get broken by it, submitters get immediate feedback about it and can iterate by themselves to fix that, without any need of your intervention. And, in fact, you can do the same for missing tests. Just enable the nose (or equivalent) code coverage plugin and make it fail if the coverage is not up to a given standard or threshold, and there too you automatically send the ball back in the camp of code contributors if they don't show up with tests. I don't know if BitBucket has any CI integration, but I'd be surprised if it doesn't. Aside from that aspect, this seem unrelated to the "lower barriers for contribution due to what is well-known out there". (But is an interesting discussion anyway!) Cheers -- Stefano Zacchiroli . z...@upsilon.cc . upsilon.cc/zack . . o . . . o . o Computer Science Professor . CTO Software Heritage . . . . . o . . . o o Former Debian Project Leader & OSI Board Director . . . o o o . . . o . « the first rule of tautology club is the first rule of tautology club » -- You received this message because you are subscribed to the Google Groups "Beancount" group. To unsubscribe from this group and stop receiving emails from it, send an email to beancount+unsubscr...@googlegroups.com. To post to this group, send email to beancount@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/beancount/20180331090248.GD13350%40upsilon.cc. For more options, visit https://groups.google.com/d/optout.
