Hello Alexis, Thanks for this new contribution. Looks very nice indeed. I'll test it in details in the coming days.
A quick note about dependencies. I would very much love to keep the dependency on account_banking_payment_export to avoid pulling all the banking framework. Did you add it only to get payment_mode_type.payment_order_type? I notice it's default value is payment anyway, so can we leave it out in account_banking_sepa_credit_transfer? I imagine it could create issues when installing account_banking_payment after account_banking_payment_export, although there must be a solution for that. What do you think? -sbi PS: there are a couple of conflicts in the diff. -- https://code.launchpad.net/~akretion-team/banking-addons/70-sepa-credit-transfer-update/+merge/194948 Your team Banking Addons Core Editors is requested to review the proposed merge of lp:~akretion-team/banking-addons/70-sepa-credit-transfer-update into lp:banking-addons. -- Mailing list: https://launchpad.net/~banking-addons-team Post to : [email protected] Unsubscribe : https://launchpad.net/~banking-addons-team More help : https://help.launchpad.net/ListHelp
