Review: Needs Fixing

Hi Frédéric,

I understand it is difficult to report as a bug.

I did a quick test and IMHO, proposing the payment line date as default is 
indeed an improvement to the default behaviour. I suggest documenting it as a 
feature of the module in __openerp__.py.

I also noticed that if line.date is null (which is allowed), it is not possible 
to add the payment line to the statement. I suggest writing something such as 
'date': line.date or line.ml_maturity_date or time.strftime('%Y-%m-%d'),

-sbi

-- 
https://code.launchpad.net/~camptocamp/banking-addons/bank-statement-reconcile-payment_line_date/+merge/181720
Your team Banking Addons Core Editors is requested to review the proposed merge 
of lp:~camptocamp/banking-addons/bank-statement-reconcile-payment_line_date 
into lp:banking-addons/bank-statement-reconcile-70.

-- 
Mailing list: https://launchpad.net/~banking-addons-team
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~banking-addons-team
More help   : https://help.launchpad.net/ListHelp

Reply via email to