Review: Needs Fixing

Thank you for your work! Nearly there, I think.

l.350..356 I find that very hard to believe. These spaces are now literals in 
the regular expression that do not occur in the field format if I read it 
correctly. Or do am I overlooking some kind of switch here that marks all 
whitespace as optional?

l.387 This print statement I overlooked earlier. I suggest you raise an 
exception in the case of lines that the software should be able to handle, and 
log a warning otherwise. I suspect you will see a lot of problems with ':61:' 
type lines.

-- 
https://code.launchpad.net/~endiansolutions/banking-addons/ab61-nl_rabo/+merge/141149
Your team Banking Addons Team is subscribed to branch lp:banking-addons.

-- 
Mailing list: https://launchpad.net/~banking-addons-team
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~banking-addons-team
More help   : https://help.launchpad.net/ListHelp

Reply via email to