Very minor comments.
1. planet.py: from math import pi as PI
Unless there is a name conflict with the identifier being used. You could
avoid using "as" in the import. Here I guess, you wanted constants in
capitals (perhaps a linter tool required). In that case, you could write it
as import math; and use it is math.pi
2.input_parser.py
Keep the import yaml at the top along with other imports. There is no
reason to have it hidden in the methods.
3. cmdline_parser.py : You don't need a trailing blackslash here.
self.parser.add_argument("--config", dest='config_file', \
Since the break is happening within "(", the implicit line joiners will
take care of having all the arguments within ().
4. arbitory_solar_system.py:
ab_solar_system = ArbitarySolarSystem(config='system.yaml')
You could assign CONSTANTS to various .yaml files.
That said, everything else looks good to me and code was pythonic too.
I believe, you used some tools like pep8, flake8 to do automatic style
fixes.
Thank you,
Senthil
On Fri, Jul 17, 2015 at 3:55 AM, Ramesh Rajagopal <mail2.rame...@gmail.com>
wrote:
> With regards to the below thread-id, I have posted my code into github
> account. Please have a look at and review it.
>
> https://github.com/rameshrajagopal/alignment
>
> Regards,
> Ramesh
>
>
> Message: 1
> Date: Fri, 17 Jul 2015 01:13:13 +0530
> From: Gora Mohanty <g...@mimirtech.com>
> To: Bangalore Python Users Group - India <bangpypers@python.org>
> Subject: Re: [BangPypers] Fwd: Need a help on reviewing a python code.
> Message-ID:
> <
> cacimrglh7bharoas710ofojd8g2i_liynbywka1640dvk5r...@mail.gmail.com>
> Content-Type: text/plain; charset=UTF-8
>
> Hi,
>
> Just forget it. The problem statement itself is so badly broken that
> it is unfixable, IMHO. To quote from problem.txt:
> "The application will not determine the alignments itself. Instead, the
> application must be able to load a set of plugins at runtime that will
> determine
> whether a particular configuration of planets is 'aligned' according to
> whatever
> definition the plugin uses for alignment."
>
> Yes, and without the specification of an interface, I suppose Moses
> will come down from the mountain to tell us how a particular plugin
> decides how a planet is <aligned>Oh my God</aligned>. IMHO, it is just
> not worth even applying to such companies as their basic recruitment
> process seems not to work.
>
> Regards,
> Gora
>
>
> On 17 July 2015 at 00:54, Senthil Kumaran <sent...@uthcode.com> wrote:
> > Agree with Anuvrat.
> >
> > Paste your code in https://gist.github.com/ or upload it github/bitcket
> and
> > share it again. I will help with the review.
> >
> > Thanks,
> > Senthil
> >
> >
> >
> > On Thu, Jul 16, 2015 at 3:40 AM, Anuvrat Parashar <anuv...@anuvrat.in>
> > wrote:
> >
> >> 1. alignment.tar.gs is missing.
> >> 2. please consider hosting the code on github / bitbucket instead of
> >> attaching heavy files.
> >>
> >>
> >> On Thu, Jul 16, 2015 at 3:49 PM, Ramesh Rajagopal <
> mail2.rame...@gmail.com
> >> >
> >> wrote:
> >>
> >> > ---------- Forwarded message ----------
> >> > From: "Ramesh Rajagopal" <mail2.rame...@gmail.com>
> >> > Date: Jul 16, 2015 3:30 PM
> >> > Subject: Fwd: Need a help on reviewing a python code.
> >> > To: <bangpypers@python.org>
> >> > Cc:
> >> >
> >> >
> >> > Hello All,
> >> >
> >> > It would be very helpful, if you can review a small code which I had
> >> > written in python. It is purely for my personal development
> perspective.
> >> >
> >> > I had a got an assignment from a company, they rejected my assignment
> >> > without exactly stating what is the problem with my code. They just
> >> > conveyed that it doesn't look like a pythonic way. I would like to
> >> > understand my mistakes and improve on this. It would be good if you
> can
> >> > help me on this.
> >> >
> >> > I am attaching the problem.txt(which has the assignment details, we
> need
> >> to
> >> > make assumptions), then solution as alignment.tar.gz file.
> >> >
> >> > Looking forward you reply.
> >> >
> >> > Regards,
> >> > Ramesh
> >> >
> >> > _______________________________________________
> >> > BangPypers mailing list
> >> > BangPypers@python.org
> >> > https://mail.python.org/mailman/listinfo/bangpypers
> >> >
> >> >
> >>
> >>
> >> --
> >> Anuvrat Parashar <http://anuvrat.in>
> >> http://anuvrat.in
> >> _______________________________________________
> >> BangPypers mailing list
> >> BangPypers@python.org
> >> https://mail.python.org/mailman/listinfo/bangpypers
> >>
> > _______________________________________________
> > BangPypers mailing list
> > BangPypers@python.org
> > https://mail.python.org/mailman/listinfo/bangpypers
> _______________________________________________
> BangPypers mailing list
> BangPypers@python.org
> https://mail.python.org/mailman/listinfo/bangpypers
>
_______________________________________________
BangPypers mailing list
BangPypers@python.org
https://mail.python.org/mailman/listinfo/bangpypers
