On Fri, Apr 12, 2024, at 8:27 AM, Martin Simmons wrote:
>>>>>> On Thu, 11 Apr 2024 16:34:48 -0400, Dan Langille said:
>> 
>> A problem with building the S3 options on Bacula 15.0.2 has been reported[1] 
>> and I'm trying to figure it out. I'm not an s3 user myself, and I am the 
>> maintainer of the FreeBSD port/package.
>> 
>> When building 13.0.4, see:
>> 
>> src/stored/.libs/bacula-sd-cloud-s3-driver.so
>> src/stored/.libs/bacula-sd-cloud-s3-driver-13.0.4.so
>> 
>> When building 15.0.2, I see
>> 
>> src/stored/.libs/bacula-sd-cloud-driver.so
>> src/stored/.libs/bacula-sd-cloud-driver-15.0.2.so
>> 
>> Of note, the '-s3' part of the name has been removed. That doesn't seem to 
>> be my problem though.
>
> These are different libraries and you need both of them
> (bacula-sd-cloud-driver loads bacula-sd-cloud-s3-driver if required).  I think
> this is the same in 13.0.4.
>
>> The problem is the files do not get installed, and I'm not sure why.
>
> The build log contains:
>
> checking libs3.h usability... no
> checking libs3.h presence... no
> checking for libs3.h... no
>
> so that looke like the problem.  Where is your libs3.h?

First goal, who supplies that?

Searching at https://www.freshports.org by pkg-plist, I find 
sysutils/bacula-libs3

How is that used:

[12:30 pkg01 dvl ~/ports/head/sysutils] % grep -r bacula-libs3 bacula*          
            
bacula11-server/Makefile:LIB_DEPENDS+=          libs3.so:sysutils/bacula-libs3
bacula13-server/Makefile:LIB_DEPENDS+=          libs3.so:sysutils/bacula-libs3
bacula15-server/Makefile:MS3_LIB_DEPENDS=       libs3.so:sysutils/bacula-libs3

Interesting how it's MS3 for 15, and S3 for 11 and 13. I have only myself to 
blame and I have no idea why it's like that.

It appears to be cruft leftover from my mangled transformation from "if 
${PORT_OPTIONS:MS3}" to modern methods.

compare old and new:

https://cgit.freebsd.org/ports/tree/sysutils/bacula13-server/Makefile#n135
https://cgit.freebsd.org/ports/tree/sysutils/bacula15-server/Makefile#n136

Doing this change allowed the build:

[14:41 pkg01 dvl ~/ports/head/sysutils/bacula15-server] % git diff .
diff --git a/sysutils/bacula15-server/Makefile 
b/sysutils/bacula15-server/Makefile
index 6e7aec421cd7..a9d84c4720a0 100644
--- a/sysutils/bacula15-server/Makefile
+++ b/sysutils/bacula15-server/Makefile
@@ -133,10 +133,10 @@ MTX_RUN_DEPENDS=  ${LOCALBASE}/sbin/mtx:misc/mtx
 
 .endif
 
-.include <bsd.port.pre.mk>
+S3_CONFIGURE_ARGS=     --enable-s3
+S3_LIB_DEPENDS=        libs3.so:sysutils/bacula-libs3
 
-MS3_CONFIGURE_ARGS=    --enable-s3
-MS3_LIB_DEPENDS=       libs3.so:sysutils/bacula-libs3
+.include <bsd.port.pre.mk>
 
 .if defined(WITH_CLIENT_ONLY)
 MP8+=          bacula.8 bacula-fd.8 bconsole.8

Now I find:

root@140amd64-dvl-primary:/wrkdirs/usr/ports/sysutils/bacula15-server/work # 
find . -name bacula-sd-cloud-s3-driver.so
./stage/usr/local/lib/bacula-sd-cloud-s3-driver.so
./bacula-15.0.2/src/stored/.libs/bacula-sd-cloud-s3-driver.so

Thanks for help me find my own error. I'll pass this onto the user for testing.

-- 
  Dan Langille
  d...@langille.org


_______________________________________________
Bacula-users mailing list
Bacula-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bacula-users

Reply via email to