Hello Peter, Yes, I am perfectly aware of your patch, but unfortunately it came in too late to be included in Bacula 7.4.0.
On a quick glance, your patch looks acceptable, but I have not yet applied it. I will accept it. What I recommend is to open a Feature Request (or bug report) with a title something like: [PATCH] Implement better restricted console help command then attach the patch to the bug report. That will guarantee that I don't miss it during the next backport of Bacula Enterprise features and integration of submissions, which will probably occur in April (tomorrow morning I am leaving for a vacation in Australia :-)) I don't think I have a Copyright Assignment Agreement from you, if you have already sent it, sorry for asking a second time, otherwise, please go to: www.bacula.org -> General -> Licenses then scroll to the bottom and read about the Copyright Assignment Agreement (CAA), download the document from the link: http://www.bacula.org/downloads/CAA-bacula.en.pdf print it, fill it out, sign it, and either post me the document or scan the document (the whole document please) and email it to me. Thanks for the patch -- I and all Bacula users thank you for your contribution, Best regards, Kern On 01/23/2016 08:36 PM, Peter Keller wrote: > On 01/18/2016 11:29 AM, Peter Keller wrote: >> Hello! >> >> On 12/29/2015 03:12 AM, Kern Sibbald wrote: >>> The only current possibility is to not permit the help command. Making the >>> help >>> command recognized which commands are permitted would be a significant >>> project >>> which is not currently on our task list. However, it would be nice if >>> someone >>> would contribute it :-) >> I have written the patch and would like to contribute it. I'll give a summary >> of the output of the patch and then attach the patch itself. I have also sent >> in the CAA document. > Any comments on this patch? Has it been accepted? Does it need changes? > Is this the right venue to post it? > > Thank you! > > -pete > > ------------------------------------------------------------------------------ > Site24x7 APM Insight: Get Deep Visibility into Application Performance > APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month > Monitor end-to-end web transactions and take corrective actions now > Troubleshoot faster and improve end-user experience. Signup Now! > http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140 > _______________________________________________ > Bacula-users mailing list > Bacula-users@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/bacula-users > ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140 _______________________________________________ Bacula-users mailing list Bacula-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bacula-users
