Are you sure about that? AFAIKS, the code in find_files() calls find_one_file() on each item in the name_list of each item in the include_list. The original fileset with duplicate File= lines will cause duplicate walking (i.e. stat of every file and subdirectory).
__Martin >>>>> On Thu, 27 Nov 2014 20:31:00 +0100, Kern Sibbald said: > > Hello, > > I don't want to comment on the details of the FileSets as what you guys > (and gal) are talking about is a bit complicated. > > However, I can re-assure you that Bacula walks the directory tree only > once. Once it has found a file, it then walks down all the Include and > Option blocks, so if you have multiple Options and/or multiple Includes, > it will go through a bit more code, but I suspect that the extra > overhead is negligible compared to the time to find each file ... > > Best regards, > Kern > > On 11/27/2014 07:40 PM, Martin Simmons wrote: > > Having two Include clauses is wasteful because it causes Bacula to walk the > > directory tree twice. Why not combine them like this? > > > > FileSet { > > Name = "MyFileSet" > > Include { > > Options { > > # Files that we don't want to compress. > > wildfile = "*.zip" > > wildfile = "*.gz" > > } > > Options { > > # Default options for everything else. > > Compression=GZIP > > } > > File = /mydirectory1 > > File = /mydirectory2 > > } > > } > > > > __Martin > > > > > >>>>>> On Thu, 27 Nov 2014 13:53:11 -0300, Ana Emília M. Arruda said: > >> Hello Uwe, > >> > >> You can have more than one include resource within the FileSet. So you can > >> have one with compression enabled and one with compression disabled. The > >> firt include you only backup your .zip, .gz, etc., files without > >> compression, the second one you backup all files except your *.gz, *.zip, > >> etc., files with compression. > >> > >> FileSet { > >> Name = "MyFileSet" > >> Include { > >> Options { > >> wildfile = "*.zip" > >> wildfile = "*.gz" > >> } > >> Options { > >> Exclude = yes > >> RegexFile = ".*" > >> } > >> File = /mydirectory1 > >> File = /mydirectory2 > >> } > >> Include { > >> Options { > >> Compression=GZIP > >> wildfile = "*.zip" > >> wildfile = "*.gz" > >> Exclude = yes > >> } > >> File = /mydirectory1 > >> File = /mydirectory2 > >> } > >> } > >> > >> Best regards, > >> Ana > >> > >> On Thu, Nov 27, 2014 at 7:48 AM, Uwe Schuerkamp <uwe.schuerk...@nionex.net> > >> wrote: > >> > >>> HI folks, > >>> > >>> is it possible to disable compression based on a file extension basis, > >>> say like skipping all files ending in .zip or .gz? > >>> > >>> Thanks, > >>> > >>> Uwe > >>> -- > >>> NIONEX --- Ein Unternehmen der Bertelsmann SE & Co. KGaA > >>> > >>> > >>> > >>> > >>> ------------------------------------------------------------------------------ > >>> Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server > >>> from Actuate! Instantly Supercharge Your Business Reports and Dashboards > >>> with Interactivity, Sharing, Native Excel Exports, App Integration & more > >>> Get technology previously reserved for billion-dollar corporations, FREE > >>> > >>> http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk > >>> _______________________________________________ > >>> Bacula-users mailing list > >>> Bacula-users@lists.sourceforge.net > >>> https://lists.sourceforge.net/lists/listinfo/bacula-users > >>> > > ------------------------------------------------------------------------------ > > Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server > > from Actuate! Instantly Supercharge Your Business Reports and Dashboards > > with Interactivity, Sharing, Native Excel Exports, App Integration & more > > Get technology previously reserved for billion-dollar corporations, FREE > > http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk > > _______________________________________________ > > Bacula-users mailing list > > Bacula-users@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/bacula-users > > ------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk _______________________________________________ Bacula-users mailing list Bacula-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bacula-users