>>>>> On Fri, 15 Jun 2007 14:18:48 +0200, Kern Sibbald said: > > Hello, > > I am now working on bug #807, where decrypting files gets signature digest > errors on each file restored. As far as I can tell, these are *false* error > messages, most likely due to the fact that Microsoft BackupWrite() does not > restore exactly the same bits as BackupRead() gave. > > Anyway, in looking at the encryption code in detail, which I have not totally > finished, I come to realize that there are some important problems that need > fixing. > > ... > > 3. In computing the signature digest, during a restore, it first writes the > file to disk, then re-reads the whole file computing the digest that it > compares to the original. This is very inefficient, and I am planning > to change it in version 2.2.0 to compute the signature digest as it > reads the data from the SD, and thus to skip reading the file after it > is written. > > Upside -- *much* more efficient; the current signature errors > will be eliminated. > > Downside -- it is probably better to compute the signature from the > actual file written in case something goes wrong in writing it. However, > this doesn't work.
I would be wary about changing this without knowing exactly which bits are different between BackupWrite and BackupRead. It really depends on the purpose of the signature -- some users might expect it to be a check that the restored filesystem is the same as saved one. __Martin ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ Bacula-users mailing list Bacula-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bacula-users
