On Friday 29 December 2006 00:36, Mike wrote:
> I'm not pointing fingers, I'm trying to figure out why one of my
> machines will just freeze. The box is a FC5 that is up to date with
> all patches. Currently it is running bacula 1.38.11 and other stuff.
> Since Saturday evening the box has frozen maybe eight times so
> hard that I cannot login. The only way to get into the box is to
> power the box off and hope everything comes back.
> 
> Today I turned off bacula (service bacula stop) and the box has
> not frozen. Is there possibly a situation where something in
> bacula is getting such a huge list of files that it starts swapping
> or something similiar? When the box freezes there are no full filesystems
> and the brief glimpse of 'top' didn't show any processes that I
> found interesting.
> 

Here is the patch that I mentioned:

tree b9b06d8b289d6c9bdb401282497079c4a5b2792c
parent 9f434d4f84a235f6b61aec6e691d6b07bc46fc24
author Bryan Holty <[EMAIL PROTECTED]> 1143030939 -0600
committer James Bottomley <[EMAIL PROTECTED]> 1149171415 -0500

[SCSI] scsi_lib.c: properly count the number of pages in scsi_req_map_sg()

The calculation of nr_pages in scsi_req_map_sg() doesn't account for
the fact that the first page could have an offset that pushes the end
of the buffer onto a new page.

Signed-off-by: Bryan Holty <[EMAIL PROTECTED]>
Signed-off-by: James Bottomley <[EMAIL PROTECTED]>
f52359622fa25783cf1a08c0772048d2ed1a7434
 drivers/scsi/scsi_lib.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index 764a8b3..faee475 100644
--- a/drivers/scsi/scsi_lib.c
+++ b/drivers/scsi/scsi_lib.c
@@ -367,7 +367,7 @@ static int scsi_req_map_sg(struct reques
                           int nsegs, unsigned bufflen, gfp_t gfp)
 {
        struct request_queue *q = rq->q;
-       int nr_pages = (bufflen + PAGE_SIZE - 1) >> PAGE_SHIFT;
+       int nr_pages = (bufflen + sgl[0].offset + PAGE_SIZE - 1) >> PAGE_SHIFT;
        unsigned int data_len = 0, len, bytes, off;
        struct page *page;
        struct bio *bio = NULL;

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Bacula-users mailing list
Bacula-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bacula-users

Reply via email to