On Monday 04 December 2006 05:22, Landon Fuller wrote: > > On Dec 3, 2006, at 12:06 PM, Kern Sibbald wrote: > > >> > >> These two issues appear to be due to some bugs in Robert Nelson's new > >> blocking encryption restore code. I'm going to spend today fixing > >> remaining issues there. > > > > OK, thanks. > > I've committed rewrite of the block-preserving encryption restoration > code that fixes all outstanding issues. The encryption regression > script passes 100%.
Nice, thanks. > > I know of a few remaining release critical bugs: > - HFS resource fork restoration is broken. This will be easy to fix OK, that is important. > - Signature validation on sparse files is broken. To fix this: > - We'll need to either validate signatures using the volume > stream > (and include the sparse file block lengths for security). This WILL > change the data format. > or > - Continue validating signatures using the on-disk stream, > revert > your digest change. Once the change is reverted, no data format > modifications are necessary. I prefer the first option because it is *much* faster than the second in terms of speed of restoring the files, and I believe that most people want speed. The security is nearly as good since it validates the data before it is written and that is nearly the same as validating it on disk. Finally, if the user really wants to validate the disk files, he/she can run a verify job. > - Encryption does not currently support sparse files. This will be > easy to fix. OK. > > Is there anything I'm missing? I'm planning on having most of this > done by tomorrow. As far as I know, that covers all the problems. However, I have planned to spend a good part of today on extending the encryption regression tests to explicitly cover compression and to cover real sparse files -- real sparse files behave different from ordinary files. If it can pass all those tests, I will consider it OK. Thanks for resolving these issues ... Kern > > -landonf > ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Bacula-users mailing list Bacula-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bacula-users
