[Bacula-users] Re: [Bacula-devel] Feature Request

[Kern Sibbald]

On Tuesday 22 November 2005 19:48, Phil Stracchino wrote: > Kern Sibbald wrote: > > Notes: By Kern: I would prefer to have a single new Resource called > > RunScript, and within that resource an additional directive: > > > > RunBeforeJob = Yes|No > > > > If no, it runs it after the job. > > One could also make this: > > RunsWhen: Before | After Yes, this is probably much clearer for the user ... > > (defaulting to Before) > > > It could also be further consolidated like this: > > > Job { > ... > ... > ... > RunScripts { > Script { > Command = c:/bacula/systemstate.bat > RunsWhen = Before # Before | After > RunsOnClient = yes # yes | no > RunsAtJobLevels = All # All | Full | Diff | Inc > AbortJobOnError = No # yes | no > RunsOnSuccess = Yes # yes | no > RunsOnFailure = Yes # yes | no > } > Script { > Command = .... > } > } > } I guess I would prefer to allow multiple "Command" lines in the RunScript resource, and there is no reason why one could not have as many RunScript resources as one wanted, it would just be necessary to iterate through all of them before and after the job, and when sending client instructions ... > > The AbortJobOnError, RunsOnSuccess and RunsOnFailure directives could be > optional, and possibly RunsWhen as well. > > If omitted, RunsWhen would default to Before. > > AbortJobOnError would be ignored unless RunsWhen was set to Before (or > RunsBefore Job set to Yes), and would default to Yes if omitted. If > AbortJobOnError was set to No, failure of the script would still > generate a warning. > > RunsOnSuccess would be ignored unless RunsWhen was set to After (or > RunsBeforeJob set to No), and default to Yes. > > RunsOnFailure would be ignored unless RunsWhen was set to After, and > default to No. > > Failure of scripts run after the job should always produce a warning. OK, thanks. I've noted all this in the Feature Request. -- Best regards, Kern ("> /\ V_V