>>>>> On Thu, 20 Oct 2005 17:14:26 -0500, Steve Greenland <[EMAIL PROTECTED]> 
>>>>> said:

  Steve> (No need to CC me, I'm on the list)

Ah, sorry.


  Steve> On Thu, Oct 20, 2005 at 10:31:04PM +0100, Martin Simmons wrote:
  >> A common reason for this problem is that the padding bytes at the end of 
the
  >> sockaddr_in object (called something like sin_zero) are not actually zero.
  >> Typically this happens when the code fails to initialize them.
  >> 
  >> Unfortunately, there has been an outbreak of C++ in this code so it is
  >> impossible to be sure whether it does this :-(

  Steve> Heh. 

  >> If you can look at the raw bytes passed to bind() in the debugger,
  >> then you might be able to see what they are.

  Steve> Ok, I stepped to the point just before the call to bind, and printed
  Steve> what I *think* is the relevant portion:

  Steve> (gdb) print/x *(p->saddr4)
  Steve> $3 = {sin_len = 0x10, sin_family = 0x2, sin_port = 0x238e, sin_addr = {
  Steve>     s_addr = 0x7f000001}, sin_zero = {0x55, 0x55, 0x55, 0x55, 0x55, 
0x55, 
  Steve>     0x55, 0x55}}

  Steve> And yes, you're correct, the extra stuff is not zero. Gotcha, you 
little
  Steve> bugger.

  Steve> So: in src/lib/address_conf.c, for both constructors:

  Steve> IPADDR::IPADDR(const IPADDR &src) : type(src.type)
  Steve> IPADDR::IPADDR(int af) : type(R_EMPTY)

  Steve> add:

  Steve>   memset(&saddrbuf, 0, sizeof(saddrbuf));

  Steve> before doing anything else to/with saddrbuf.

  Steve> This fixes the problem: I can now bind to arbitrary addresses (well, at
  Steve> least the ones that exist on the box). 

  Steve> Martin, you're my new hero. Kern, did you catch this? Should I send
  Steve> the patch someplace specific? Actually, I prefer that someone who
  Steve> actually understands C++ confirm that this is patch is both correct and
  Steve> sufficient...

Possibly the IPADDR::IPADDR(const IPADDR &src) method doesn't need it, because
it copies the saddrbuf of an existing one?

Anyway, I suggest sending the patch to the bacula-devel list.

__Martin


-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl
_______________________________________________
Bacula-users mailing list
Bacula-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bacula-users

Reply via email to